-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Validator] Add getConstraint()
method to ConstraintViolationInterface
#48671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Validator] Add getConstraint()
method to ConstraintViolationInterface
#48671
Conversation
syl20b
commented
Dec 15, 2022
Q | A |
---|---|
Branch? | 6.3 |
Bug fix? | no |
New feature? | yes |
Deprecations? | yes |
Tickets | Fix #48626 |
License | MIT |
Doc PR |
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
63ffded
to
c939002
Compare
Hey! I think @alexandre-daubois has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
Ah, we should probably also document this in |
c939002
to
f690632
Compare
UPGRADE-6.3 updated ;) |
getConstraint()
method to
ConstraintViolationInterface`
getConstraint()
method to
ConstraintViolationInterface`getConstraint()
method to ConstraintViolationInterface
f690632
to
0118348
Compare
Thank you @syl20b. |