Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WebProfilerBundle] Add a title and img role to svg of the web debug toolbar #48696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

Saladeuh
Copy link

@Saladeuh Saladeuh commented Dec 17, 2022

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT

This changes improves the accessibility for blind/low vision developpers. This have not visible effect for not impaired developpers.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@javiereguiluz
Copy link
Member

@Saladeuh thanks for this. It's a good idea to improve accessibility like this.

The problem is that in this PR you've removed all the new icons that we added in the profiler redesign (see #47148) and you used the legacy icons. So, please update this PR to add the <title> to the new icons. Thanks.

@Saladeuh
Copy link
Author

Thank @javiereguiluz ! I'm sorry, I modified the icons from a 5.4 project. It would be better now.

@nicolas-grekas nicolas-grekas changed the title [WebProfilerBundle] Add a title and img role to svg of the web debug … [WebProfilerBundle] Add a title and img role to svg of the web debug toolbar Dec 18, 2022
6.3
---

* Add a role=img and a explicit title in the .svg using in the toolbar to improve accessibility with screen readers for blind users
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space at start of line

@@ -6,6 +6,7 @@ CHANGELOG

* Deprecate enabling bundle and not configuring it
* Add `_stateless` attribute to the request when firewall is stateless
* Modify the icon.svg to improve accesssibility for blind/low vision developpers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accessibility and developers

@fabpot
Copy link
Member

fabpot commented Dec 19, 2022

Thank you @Saladeuh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants