-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[WebProfilerBundle] Add a title and img role to svg of the web debug toolbar #48696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Thank @javiereguiluz ! I'm sorry, I modified the icons from a 5.4 project. It would be better now. |
e2491e2
to
81d68bf
Compare
6.3 | ||
--- | ||
|
||
* Add a role=img and a explicit title in the .svg using in the toolbar to improve accessibility with screen readers for blind users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing space at start of line
@@ -6,6 +6,7 @@ CHANGELOG | |||
|
|||
* Deprecate enabling bundle and not configuring it | |||
* Add `_stateless` attribute to the request when firewall is stateless | |||
* Modify the icon.svg to improve accesssibility for blind/low vision developpers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accessibility
and developers
Thank you @Saladeuh. |
81d68bf
to
ef6a182
Compare
This changes improves the accessibility for blind/low vision developpers. This have not visible effect for not impaired developpers.