[HttpFoundation] Add support for \SplTempFileObject in BinaryFileResponse
#49144
Conversation
1ff0704 to
0c52104
Compare
|
Hey! I think @alli83 has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
|
Would it be possible to add support in |
0c52104 to
b1a7fbf
Compare
|
It doesn't seem to. |
|
BinaryFileResponse accepts an SplFileInfo as argument and SplTempFileObject extends SplFileInfo, so it's already possible to pass a SplTempFileObject there. Can't we make BinaryFileResponse able to deal with such instances, skipping all the features that need a physical file when this happens? |
6294b4a to
0151376
Compare
StreamedResponse::createFromTempFile()\SplTempFileObject in BinaryFileResponse
|
Thank you for the hint Nicolas, I tried a implementation in |
0151376 to
8859741
Compare
|
@alexandre-daubois Can you rebase on current 7.1? Thank you. |
8859741 to
7b6ad2c
Compare
|
Yep of course, here you go 🙂 |
|
Thank you @alexandre-daubois. |
…BinaryFileResponse` (elementaire) This PR was merged into the 7.1 branch. Discussion ---------- [HttpFoundation] Fix support for `\SplTempFileObject` in `BinaryFileResponse` | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | PR original Feature | #49144 | New feature? | no | Deprecations? | no | Issues | - | License | MIT We can not call some methods with an object of `\SplTempFileObject()`. We get this error: `[...] stat failed for php://temp`. I have checked the code against methods listed in [this note](https://www.php.net/manual/en/class.spltempfileobject.php#128962). I have found: - `getMTime()` called in `BinaryFileResponse::setAutoLastModified()` - `getSize()` called in `BinaryFileResponse::prepare()` - `isReadable()` called in `BinaryFileResponse::setFile()` (already safe) I have updated the unit test and patched the class `BinaryFileResponse`. Note: calling `SplFileObject::fstat()` gives `mtime` equals to `0`. I think it is nonsense to use that as value for last modified. I have decided to use `time()` because i guess, we can not do better. Indeed, we have no idea how much time have passed between making the temp file and the call to `setAutoLastModified()` by the developper. Commits ------- a104d50 Fix support for \SplTempFileObject in BinaryFileResponse
Add support for
\SplTempFileObjectinBinaryFileResponse