Use PHPUnit 9.6 to run Symfony's test suite #49233

derrabus · 2023-02-04T08:51:35Z

Q	A
Branch?	5.4
Bug fix?	no
New feature?	no
Deprecations?	no
Tickets	N/A
License	MIT
Doc PR	N/A

Let's use PHPUnit 9.6 to run test test suite if we can.

derrabus · 2023-02-04T08:52:09Z

phpunit

-    if (\PHP_VERSION_ID < 70200) {
-        putenv('SYMFONY_PHPUNIT_VERSION=7.5');


This was a leftover from Symfony 4 wasn't it?

I'd keep this, the bridge is still declared as compatible with <7.2

derrabus · 2023-02-04T08:55:48Z

All right, the output gives us a couple of tasks to work on for PHPUnit 10.

cc @OskarStark

xabbuh · 2023-02-04T09:37:08Z

👍 I would have expected a lot of messages about the deprecated setMethods() method though (see #49218). 🤔

OskarStark · 2023-02-04T09:41:44Z

It was fixed in

[Validator] Make ConstraintValidatorTestCase compatible with PHPUnit 10 #49220

Referenced PR in #49218

xabbuh · 2023-02-04T09:42:48Z

Yeah, for that particular case which is a file that can be used by users of Symfony. But we make heavy use of setMethods() in our own tests.

OskarStark · 2023-02-04T09:43:12Z

Ok... but why 🤷‍♂️ ...

That will be a lot of work for the abstract test cases in /Test/

Using `Test` suffix is deprecated since PHPUnit 10 Spooted in * symfony#49233

OskarStark · 2023-02-04T09:55:07Z

That will be a lot of work for the abstract test cases in /Test/

Oh no, we already named them *TestCase 💪

Using `Test` suffix is deprecated since PHPUnit 10 Spotted in * symfony#49233

Replaces symfony#49234 Using `Test` suffix is deprecated since PHPUnit 10 Spotted in * symfony#49233

…NotAttribute()` (xabbuh) This PR was merged into the 5.4 branch. Discussion ---------- stop using `assertObjectHasAttribute()`/`assertObjectHasNotAttribute()` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | related #49233 | License | MIT | Doc PR | Commits ------- 442b43c stop using assertObjectHasAttribute()/assertObjectHasNotAttribute()

Replaces symfony#49234 Using `Test` suffix is deprecated since PHPUnit 10 Spotted in * symfony#49233

… `/Tests/` (OskarStark) This PR was merged into the 6.3 branch. Discussion ---------- [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/` | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Refs #49233 | License | MIT | Doc PR | n/a Replaces #49234 Using `Test` suffix is deprecated since PHPUnit 10 Spotted in * #49233 Commits ------- cb3db96 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`

… `/Tests/` (OskarStark) This PR was merged into the 6.3 branch. Discussion ---------- [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/` | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Refs symfony/symfony#49233 | License | MIT | Doc PR | n/a Replaces #49234 Using `Test` suffix is deprecated since PHPUnit 10 Spotted in * symfony/symfony#49233 Commits ------- cb3db968e4 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`

derrabus · 2023-02-14T12:53:39Z

What's the fix for…

Expecting E_ERROR and E_USER_ERROR is deprecated and will no longer be possible in PHPUnit 10.

? Registering a custom error handler? 🤔

…Unit getMockClass() method (xabbuh) This PR was merged into the 5.4 branch. Discussion ---------- [WebProfilerBundle] replace usages of the deprecated PHPUnit getMockClass() method | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | related to #49233 | License | MIT | Doc PR | Commits ------- 2f7c509 replace usages of the deprecated PHPUnit getMockClass() method

xabbuh · 2023-02-14T14:11:50Z

I think it's easier: #49375 (I need to check all places though)

…certain strings (xabbuh) This PR was merged into the 5.4 branch. Discussion ---------- use proper methods to assert exception messages contain certain strings | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | related to #49233 | License | MIT | Doc PR | Commits ------- 5b3e6a5 use proper methods to assert exception messages contain certain strings

derrabus · 2023-02-14T22:01:01Z

🟢

This PR was merged into the 6.2 branch. Discussion ---------- Fix PHPUnit 9.6 deprecations | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Related to #49233 | License | MIT | Doc PR | N/A This PR fixes deprecations introduced by PHPUnit 9.6. We should merge this PR before merging up #49233. Commits ------- a6896fa Fix PHPUnit 9.6 deprecations

src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/ConfigurationTest.php

nicolas-grekas · 2023-02-15T18:33:07Z

Thank you @derrabus.

… `/Tests/` (OskarStark) This PR was merged into the 6.3 branch. Discussion ---------- [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/` | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Refs symfony/symfony#49233 | License | MIT | Doc PR | n/a Replaces #49234 Using `Test` suffix is deprecated since PHPUnit 10 Spotted in * symfony/symfony#49233 Commits ------- cb3db968e4 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`

carsonbot added the Status: Needs Review label Feb 4, 2023

carsonbot added this to the 5.4 milestone Feb 4, 2023

derrabus commented Feb 4, 2023

View reviewed changes

derrabus added Status: Needs Work and removed Status: Needs Review labels Feb 4, 2023

OskarStark added a commit to OskarStark/symfony that referenced this pull request Feb 4, 2023

[PHPUnit 10] Use TestCase suffix for abstract tests

acb8d21

Using `Test` suffix is deprecated since PHPUnit 10 Spooted in * symfony#49233

OskarStark mentioned this pull request Feb 4, 2023

[PHPUnit 10] Use TestCase suffix for abstract tests in /Tests/ #49234

Closed

xabbuh mentioned this pull request Feb 4, 2023

stop using assertObjectHasAttribute()/assertObjectHasNotAttribute() #49236

Merged

OskarStark added a commit to OskarStark/symfony that referenced this pull request Feb 4, 2023

[PHPUnit 10] Use TestCase suffix for abstract tests

a64666c

Using `Test` suffix is deprecated since PHPUnit 10 Spotted in * symfony#49233

OskarStark added a commit to OskarStark/symfony that referenced this pull request Feb 6, 2023

[PHPUnit 10] Use TestCase suffix for abstract tests in /Tests/

2c50955

Replaces symfony#49234 Using `Test` suffix is deprecated since PHPUnit 10 Spotted in * symfony#49233

OskarStark mentioned this pull request Feb 6, 2023

[PHPUnit 10] Use TestCase suffix for abstract tests in /Tests/ #49253

Merged

OskarStark added a commit to OskarStark/symfony that referenced this pull request Feb 7, 2023

[PHPUnit 10] Use TestCase suffix for abstract tests in /Tests/

ec11e84

Replaces symfony#49234 Using `Test` suffix is deprecated since PHPUnit 10 Spotted in * symfony#49233

This was referenced Feb 14, 2023

[WebProfilerBundle] replace usages of the deprecated PHPUnit getMockClass() method #49374

Merged

use proper methods to assert exception messages contain certain strings #49375

Merged

derrabus force-pushed the improvement/phpunit-9.6 branch 2 times, most recently from ecbe5b7 to 4237f77 Compare February 14, 2023 18:12

derrabus requested review from xabbuh and yceruto as code owners February 14, 2023 18:12

carsonbot added Status: Needs Review and removed Status: Needs Work labels Feb 14, 2023

derrabus force-pushed the improvement/phpunit-9.6 branch 4 times, most recently from 493a9b9 to efd7cbb Compare February 14, 2023 21:51

This was referenced Feb 14, 2023

Use PHPUnit 9.6 to run Symfony's test suite #49380

Closed

Fix PHPUnit 9.6 deprecations #49381

Merged

derrabus requested a review from nicolas-grekas February 15, 2023 17:59

nicolas-grekas reviewed Feb 15, 2023

View reviewed changes

src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/ConfigurationTest.php Outdated Show resolved Hide resolved

Use PHPUnit 9.6 to run Symfony's test suite

e1ca0aa

derrabus force-pushed the improvement/phpunit-9.6 branch from efd7cbb to e1ca0aa Compare February 15, 2023 18:14

nicolas-grekas merged commit c7a7cb8 into symfony:5.4 Feb 15, 2023

derrabus deleted the improvement/phpunit-9.6 branch February 15, 2023 18:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use PHPUnit 9.6 to run Symfony's test suite #49233

Use PHPUnit 9.6 to run Symfony's test suite #49233

derrabus commented Feb 4, 2023

derrabus Feb 4, 2023

nicolas-grekas Feb 15, 2023

derrabus commented Feb 4, 2023

xabbuh commented Feb 4, 2023

OskarStark commented Feb 4, 2023 •

edited

Loading

xabbuh commented Feb 4, 2023

OskarStark commented Feb 4, 2023 •

edited

Loading

OskarStark commented Feb 4, 2023

derrabus commented Feb 14, 2023

xabbuh commented Feb 14, 2023

derrabus commented Feb 14, 2023

nicolas-grekas commented Feb 15, 2023

		if (\PHP_VERSION_ID < 70200) {
		putenv('SYMFONY_PHPUNIT_VERSION=7.5');

Use PHPUnit 9.6 to run Symfony's test suite #49233

Use PHPUnit 9.6 to run Symfony's test suite #49233

Conversation

derrabus commented Feb 4, 2023

derrabus Feb 4, 2023

Choose a reason for hiding this comment

nicolas-grekas Feb 15, 2023

Choose a reason for hiding this comment

derrabus commented Feb 4, 2023

xabbuh commented Feb 4, 2023

OskarStark commented Feb 4, 2023 • edited Loading

xabbuh commented Feb 4, 2023

OskarStark commented Feb 4, 2023 • edited Loading

OskarStark commented Feb 4, 2023

derrabus commented Feb 14, 2023

xabbuh commented Feb 14, 2023

derrabus commented Feb 14, 2023

nicolas-grekas commented Feb 15, 2023

OskarStark commented Feb 4, 2023 •

edited

Loading

OskarStark commented Feb 4, 2023 •

edited

Loading