Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Smsapi - Make "from" optional #49261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2023
Merged

Smsapi - Make "from" optional #49261

merged 1 commit into from
Feb 10, 2023

Conversation

szal1k
Copy link
Contributor

@szal1k szal1k commented Feb 6, 2023

Smsapi.com API have option to send "eco" messages, default with drawn phone number instead of "from" name defined in Smsapi.com User Panel.

So, when from is not set in body of request, in default message is send as "eco". My changes make it possible.

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR

@szal1k szal1k requested a review from OskarStark as a code owner February 6, 2023 14:08
@carsonbot carsonbot added this to the 6.3 milestone Feb 6, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@chalasr chalasr changed the title Make "from" optional [Notifier] Make "from" optional Feb 6, 2023
@carsonbot carsonbot changed the title [Notifier] Make "from" optional Make "from" optional Feb 6, 2023
@szal1k szal1k requested review from stof and removed request for OskarStark February 6, 2023 14:39
@szal1k szal1k changed the title Make "from" optional [Notifier] Make "from" optional Feb 6, 2023
@szal1k szal1k changed the title [Notifier] Make "from" optional [Notifier] Smsapi - Make "from" optional Feb 6, 2023
@OskarStark
Copy link
Contributor

Something went wrong with the rebase I guess, can you please check again? Thanks

@fabpot
Copy link
Member

fabpot commented Feb 10, 2023

@szal1k Can you rebase to get rid of the merge commits?

@szal1k szal1k force-pushed the 6.3-notifier-smsapi-make-from-optional branch from 5d319af to 74c4984 Compare February 10, 2023 16:07
@carsonbot carsonbot changed the title [Notifier] Smsapi - Make "from" optional Smsapi - Make "from" optional Feb 10, 2023
@fabpot
Copy link
Member

fabpot commented Feb 10, 2023

Thank you @szal1k.

@fabpot fabpot force-pushed the 6.3-notifier-smsapi-make-from-optional branch from 2745fa9 to 8b14052 Compare February 10, 2023 16:28
@fabpot fabpot mentioned this pull request Feb 10, 2023
Closed
@fabpot fabpot merged commit 039e883 into symfony:6.3 Feb 10, 2023
@szal1k
Copy link
Contributor Author

szal1k commented Feb 10, 2023

@fabpot @OskarStark Done, thanks for your support.

@xabbuh xabbuh mentioned this pull request Feb 18, 2023
Merged
@fabpot fabpot mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof Awaiting requested review from stof

@xabbuh xabbuh Awaiting requested review from xabbuh

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@jderusse jderusse Awaiting requested review from jderusse

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
5 participants
@szal1k @carsonbot @OskarStark @fabpot @stof