-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Mailer] Add MailerSend bridge #49461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
...ymfony/Component/Mailer/Bridge/MailerSend/Tests/Transport/MailerSendTransportFactoryTest.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I have only minor comments.
...ymfony/Component/Mailer/Bridge/MailerSend/Tests/Transport/MailerSendTransportFactoryTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MailerSend/Transport/MailerSendApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MailerSend/Transport/MailerSendApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MailerSend/Transport/MailerSendApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MailerSend/Transport/MailerSendApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MailerSend/Transport/MailerSendApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/MailerSend/Transport/MailerSendApiTransport.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks, just a note about toArray if that makes sense to you
Thank you @doobas. |
This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [Mailer] Add MailerSend bridge | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | License | MIT | Doc PR | symfony/symfony-docs#17926 | Recipes PR | symfony/recipes#1177 Added MailerSend as new email provider for Symfony Mailer! Commits ------- fdc22ef [Mailer] Add MailerSend bridge
Merged as b87aa86 |
This PR was merged into the 6.3 branch. Discussion ---------- [Mailer] Add MailerSend bridge symfony/symfony#49461 Commits ------- fcf3c27 [Mailer] Add MailerSend bridge
Added MailerSend as new email provider for Symfony Mailer!