Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Mailer] Add MailerSend bridge #49461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

doobas
Copy link
Contributor

@doobas doobas commented Feb 21, 2023

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
License MIT
Doc PR symfony/symfony-docs#17926
Recipes PR symfony/recipes#1177

Added MailerSend as new email provider for Symfony Mailer!

@carsonbot
Copy link

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@doobas doobas marked this pull request as ready for review February 21, 2023 09:09
@carsonbot carsonbot added this to the 6.3 milestone Feb 21, 2023
@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have only minor comments.

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks, just a note about toArray if that makes sense to you

@nicolas-grekas
Copy link
Member

Thank you @doobas.

nicolas-grekas added a commit that referenced this pull request Feb 23, 2023
This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[Mailer] Add MailerSend bridge

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| License       | MIT
| Doc PR        | symfony/symfony-docs#17926
| Recipes PR	| symfony/recipes#1177

Added MailerSend as new email provider for Symfony Mailer!

Commits
-------

fdc22ef [Mailer] Add MailerSend bridge
@nicolas-grekas
Copy link
Member

Merged as b87aa86

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Feb 27, 2023
This PR was merged into the 6.3 branch.

Discussion
----------

[Mailer] Add MailerSend bridge

symfony/symfony#49461

Commits
-------

fcf3c27 [Mailer] Add MailerSend bridge
@fabpot fabpot mentioned this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants