You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Method Filesystem::doRemove is using renaming of parent directory before recursive removal, in order to implement atomic remove.
This is a good thing, but to implement this is generating a random path name, with a modified base64 which replaces base64's = sign with .. This may lead to directory named as path/..8U6/ which freaked out our synchronization tools and security log scanner.
Since the leading . is already (correctly) hard-coded, I see no issue in using _ as a safer alternative.
Are these tools right when they consider this path as risky? To my knowledge, there is no risk of accessing the parent directory here.
But this change looks good anyway, someone seeing a path like path/..8U6/ could be confused too.
Precisely as you say.
The tools aren't right, strictly speaking, but usually when I find /a/path/..like/this, I verify that there are no fishy patterns, like a GET /?request=..like/this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method
Filesystem::doRemoveis using renaming of parent directory before recursive removal, in order to implement atomic remove.This is a good thing, but to implement this is generating a random path name, with a modified base64 which replaces base64's
=sign with.. This may lead to directory named aspath/..8U6/which freaked out our synchronization tools and security log scanner.Since the leading
.is already (correctly) hard-coded, I see no issue in using_as a safer alternative.