Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SecurityBundle] Fix configuring OIDC user info token handler client #50470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2023
Merged

[SecurityBundle] Fix configuring OIDC user info token handler client #50470

merged 1 commit into from
May 30, 2023

Conversation

vincentchalamon
Copy link
Contributor

@vincentchalamon vincentchalamon commented May 30, 2023 •
edited
Loading

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR symfony/symfony-docs#18354

Cf. #50453 (comment)

@carsonbot carsonbot added this to the 6.3 milestone May 30, 2023
@vincentchalamon vincentchalamon mentioned this pull request May 30, 2023
Merged
@vincentchalamon vincentchalamon force-pushed the fix/security/oidc_user_info-token_handler-client branch 7 times, most recently from dab1d31 to 8e74520 Compare May 30, 2023 12:11
@nicolas-grekas nicolas-grekas changed the title [Security] OIDC user info token handler client [Security] Fix configuring OIDC user info token handler client May 30, 2023
@nicolas-grekas nicolas-grekas changed the title [Security] Fix configuring OIDC user info token handler client [SecurityBundle] Fix configuring OIDC user info token handler client May 30, 2023
@nicolas-grekas nicolas-grekas force-pushed the fix/security/oidc_user_info-token_handler-client branch from 8e74520 to 8b7fdc1 Compare May 30, 2023 14:30
nicolas-grekas
nicolas-grekas approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tweaked the implementation a bit, see
https://github.com/symfony/symfony/compare/8e7452011403b4bbe67a4d2abd12dde3df95f0c3..8b7fdc108237bd8e88c59aa0282aa6d36d9ae7ad

TL;DR, the base_uri option is required, and the client option can be used optionally to configure any other options.

@vincentchalamon vincentchalamon force-pushed the fix/security/oidc_user_info-token_handler-client branch from 402101b to 86ab255 Compare May 30, 2023 14:42
@nicolas-grekas nicolas-grekas force-pushed the fix/security/oidc_user_info-token_handler-client branch from 86ab255 to 23c9e17 Compare May 30, 2023 14:46
@nicolas-grekas
Copy link
Member

Thank you @vincentchalamon.

@nicolas-grekas nicolas-grekas merged commit 5c46e7e into symfony:6.3 May 30, 2023
@vincentchalamon vincentchalamon deleted the fix/security/oidc_user_info-token_handler-client branch May 30, 2023 14:47
aegypius added a commit to aegypius/symfony that referenced this pull request May 30, 2023
@aegypius
fix(security): allow oidc-user-info as an attribute of token-handler
a4deb22 
Ref: symfony#50470
aegypius added a commit to aegypius/symfony that referenced this pull request May 30, 2023
@aegypius
fix(security): allow to specify http client service name as an attribute
52280eb 
Ref: symfony#50470
@fabpot fabpot mentioned this pull request May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@mtarld mtarld mtarld left review comments

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
SecurityBundle Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@vincentchalamon @nicolas-grekas @mtarld @carsonbot