[DoctrineBridge] Ignore invalid stores in LockStoreSchemaListener raised by StoreFactory
#50761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aised by `StoreFactory`
| foreach ($this->stores as $store) { | ||
| if (!$store instanceof DoctrineDbalStore) { | ||
| continue; | ||
| $storesIterator = new \ArrayIterator($this->stores); |
There was a problem hiding this comment.
should be IteratorIterator ?
|
Thank you @alexandre-daubois. |
Merged
|
This PR make some error while using DoctrineDbalStore, in \Symfony\Bridge\Doctrine\SchemaListener\LockStoreSchemaListener. See these two picture, iterator_count is greater than zero, but
|
|
|
|
After downgrade |
remove
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our test environment, we're setting our
LOCK_DSNenv var atnull. This works well in 6.2 but not in 6.3 anymore.The version 6.3 of DoctrineBridge is bringing this BC break. Indeed, lock stores are being injected in
Symfony\Bridge\Doctrine\SchemaListener\LockStoreSchemaListener. At runtime, theStoreFactoryis used to instantiate stores when they are needed inpostGenerateSchema.Unfortunately, our
LOCK_DSN=nulldoesn't match any case inStoreFactory, which has the effect to throwSymfony\Component\Lock\Exception\InvalidArgumentException, which is not catched inLockStoreSchemaListener.This PR takes care of this: at this time,
LockStoreSchemaListeneronly deals withDoctrineDbalStore. I think it is safe to ignore any instantiation problem that may occur in theStoreFactory.