[Composer] Bumped doctrine/orm to 2.2.3 #5127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should also bump Security component deps. |
|
The security does not depend on |
fabpot
added a commit
that referenced
this pull request
Jul 31, 2012
Commits ------- 4ae54e3 [Composer] Bumped doctrine/orm to 2.2.3 Discussion ---------- [Composer] Bumped doctrine/orm to 2.2.3 fix #4966 --------------------------------------------------------------------------- by stloyd at 2012-07-31T15:01:41Z You should also _bump_ Security component [deps](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Security/composer.json#L28). --------------------------------------------------------------------------- by vicb at 2012-07-31T15:05:03Z The security does not depend on `doctrine/orm`
fabpot
added a commit
to symfony/symfony-standard
that referenced
this pull request
Jul 31, 2012
Commits ------- 793a21a Updated the lock file 59fdaeb Bumped Doctrine to 2.2.3 Discussion ---------- Doctrine deps based on #373 from @stof integrating the feedback --------------------------------------------------------------------------- by stof at 2012-07-31T14:53:00Z :+1: And the requirement on 2.2.3+ should be changed in symfony too instead of >=2.2 --------------------------------------------------------------------------- by vicb at 2012-07-31T15:00:23Z @stof that's symfony/symfony#5127. Thanks for your help.
| @@ -24,7 +24,7 @@ | |||
| "symfony/validator": "self.version", | |||
| "doctrine/data-fixtures": "1.0.*", | |||
| "doctrine/dbal": ">=2.2,<2.4-dev", | |||
| "doctrine/orm": ">=2.2,<2.4-dev" | |||
| "doctrine/orm": ">=2.2.3,<2.4-dev" | |||
| }, | |||
There was a problem hiding this comment.
AFAIK, this is not enough. ORM 2.2.3 could accept common 2.2.2. and the real 2.2.3 requirement is on Common in the bridge (thus, this does not change anything there as it is in the suggestion which is simply plain text)
There was a problem hiding this comment.
@stof there seems to be not 2.2.3 tag on doctrine/common ? May be you could submit a PR with the fix ?
There was a problem hiding this comment.
There is indeed no 2.2.3 tag in common. It will be the next 2.2.x release in common. The fix we need is not yet part of any doctrine release.
mbence
pushed a commit
to mbence/csaladsegito
that referenced
this pull request
Feb 3, 2014
Commits ------- 793a21a Updated the lock file 59fdaeb Bumped Doctrine to 2.2.3 Discussion ---------- Doctrine deps based on #373 from @stof integrating the feedback --------------------------------------------------------------------------- by stof at 2012-07-31T14:53:00Z :+1: And the requirement on 2.2.3+ should be changed in symfony too instead of >=2.2 --------------------------------------------------------------------------- by vicb at 2012-07-31T15:00:23Z @stof that's symfony/symfony#5127. Thanks for your help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4966