Do you have any ETA for Doctrine 2.3? ping @beberlei

@fabpot not a final one yet, but within august is planned.

Shouldn't this update also be done in TwigBridge's composer.json and Symfony's main composer.json?

@bschussek Symfony already allows both 2.2 and 2.3

Sure, but shouldn't it require 2.3?

well, nothing is broken with 2.2 (you simply cannot use the aliased class name for the class option in your forms). I think @beberlei wants to keep the 2.2 compatibility (even if I would consider 2.3 as highly recommended)

I would clearly call this a BC break. Aliased class names used to work, now they don't.

What's the point of still supporting 2.2?

@beberlei Can you give your reason for this ?

You can use Doctrine 2.2 stable with Symfony master since january now, i don't want to force people to upgrade their doctrine dependency if they don't have to.

Why not just use >=2.2 in the composer.json?

2.3 is not compatible with 2.2? Symfony 2.1 is not stable yet, so I don't see why we should support an older version of Doctrine.

2.3 and 2.2 are compatible, the only thing thats not compatible are the changes bernhard did in the forms, and respectively a fix in doctrine that was only done for 2.3 - @stof can we merge that manager registry fix to 2.2 as well? albeit only for 2.2.3 - but at least.

@unknownbliss 2 reasons:

1. an unbound constraint is a bad idea (we cannot ensure that the current code works for Doctrine 3, so we should not allow it in the constraint)
2. We don't want to distribute 2.3 in the SE as it would lead to a regression in forms (DoctrineBundle and Symfony still allow 2.2 so you can change the constraint to 2.2.* if you want.

@beberlei yes we could backport it to 2.2 (I even mentioned it in my PR)

@stof sorry, my oversight.

@stof wouldn't it be better if we have support only for 2.3 and fix the regressions that appear in the forms component? Also what is that regression about? Maybe someone will be able to fix it as it would totaly make sense to distribute SF2.1 with Doctrine 2.3 rather that 2.2 imho.

@dlsniper A bug in the form component (symfony/symfony#4125) was fixed by using getManagerForClass() (symfony/symfony#4953), which does not support everything we need and thus causes the regression (symfony/symfony#4966). We cannot change getManagerForClass() without changing Doctrine.

There is a difference between shipping with something by default and supporting more.

As stated before, 2.2 is stable for half a year now, why force users to upgrade to 2.3 if it is not really necessary.

Doctrine 2.2 can be used with symfony 2.0 already. Supporting 2.2 in s2.1 aswell would take one big variable out of the upgrade process for some people.

SE should point to 2.3 since it is for new projects, but the core shouldnt just bump dependemcies so eagerly imho.

Am 27.07.2012 um 08:08 schrieb Florin [email protected]:

@stof wouldn't it be better if we have support only for 2.3 and fix the regressions that appear in the forms component? Also what is that regression about? Maybe someone will be able to fix it as it would totaly make sense to distribute SF2.1 with Doctrine 2.3 rather that 2.2 imho.

---

Reply to this email directly or view it on GitHub:
#373 (comment)

I will fix the getmamagerforclass in 2.2.3 as well. So that will be taken care of.

Am 27.07.2012 um 08:27 schrieb Bernhard [email protected]:

@dlsniper A bug in the form component (symfony/symfony#4125) was fixed by using getManagerForClass() (symfony/symfony#4953), which does not support everything we need and thus causes the regression (symfony/symfony#4966). We cannot change getManagerForClass() without changing Doctrine.

---

Reply to this email directly or view it on GitHub:
#373 (comment)

Awesome, thanks Benjamin! So this PR should actually be to update all dependencies to >=2.2.3 in the Standard Distribution and Symfony Core.

@stof Can you update this PR accordingly?

Also, can someone make a PR on symfony/symfony to update Doctrine wherever needed?

@fabpot do you want this PR to state >=2.2.3,<2.4-dev or do you want to ship with 2.3 in the SE ? @beberlei said SE should point to 2.3 since it is for new projects

using >=2.2.3,<2.4-dev is fine by me as Composer will install the latest possible version and that's what we will have therefore in the lock file.