[FrameworkBundle] no serializer mapping cache in debug mode without enable_annotations #51497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Aug 27, 2023
|
Please, keep the full header in the description. |
…nable_annotations There's no reason we should disable the cache only without `enable_annotations`, when working only with attributes, in debug mode the cache is enabled which is why we often need to clear cache when changing a serialized object to get the changes.
2de525a to
4312e96
Compare
|
done I guess you spoke about the commit description |
derrabus
approved these changes
Sep 13, 2023
|
Thank you @soyuka. |
|
The reason is that for yaml/xml, it's ban by CachePoolClearerCacheWarmer (from apip...) from this PR https://github.com/symfony/symfony/pull/35109/files. With that PR, it means that all yaml/xml are parsed at each request without any change :(. |
|
@bastnic comments on merged PRs are likely to get lost. Please open a new issue if you think that you discovered an issue with this implementation and provide a small example application that allows to reproduce it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason we should disable the cache only without
enable_annotations, when working only with attributes, in debug mode the cache is enabled which is why we often need to clear cache when changing a serialized object to get the changes.