Conflict symfony/validator 7.0 in symfony/doctrine-bridge 6.3 #51630

alexander-schranz · 2023-09-11T18:53:26Z

Q	A
Branch?	5.4 / 6.3 / 6.4 -> Revert in 7.0
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix #...
License	MIT
Doc PR	symfony/symfony-docs#...

Currently it is possible to have doctrine-bridge 6.3 and validator 7.0 installed which ends in the following error:

Testing PHP Fatal error: Declaration of Symfony\Bridge\Doctrine\Validator\DoctrineInitializer::initialize(object $object) must be compatible with Symfony\Component\Validator\ObjectInitializerInterface::initialize(object $object): void in /home/runner/work/sulu/sulu/vendor/symfony/doctrine-bridge/Validator/DoctrineInitializer.php on line 34

The conflict can be removed then on the 7.0 branch where the : void return type is added.

Tested it also appears on 5.4 branch so conflict there would also be good, rebased so to 5.4.

You maybe ask why symfony/doctrine-bridge was in my example not on 7.0. If a project still is using doctrine/persistence 2.0 instead of 3.0 it can not update the bridge to 6.4 or 7.0. So it could be a common error, to avoid this I suggest to add a conflict.

carsonbot · 2023-09-11T18:53:31Z

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.3 for features / 5.4, or 6.3 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

alexander-schranz · 2023-09-11T19:09:12Z

src/Symfony/Bridge/Doctrine/composer.json

@@ -63,7 +63,7 @@
        "symfony/proxy-manager-bridge": "<4.4.19",
        "symfony/security-bundle": "<5",
        "symfony/security-core": "<5.3",
-        "symfony/validator": "<5.4.25|>=6,<6.2.12|>=6.3,<6.3.1"


Not sure if it would better to add a conflict to symfony/validator 7.0 as adding a conflict after a release in this case (5.4 and 6.3) will composer maybe just install a old version of the doctrine-bridge e.g. (5.4.28 or 6.3.4) without that conflict and then still run into the same error 🤔.

But it feels strange to add a conflict to symfony/validator as it has not even a optional dependency to the bridge.

I think we should add this conflict rule here (where it is legitimate), but we should also add it in validator 7.0 to avoid the issue of installing validator 7.0 and an outdated doctrine-bridge.

That would work I think. @nicolas-grekas what do you think about that?

nicolas-grekas · 2023-09-12T09:28:47Z

This won't work: previous versions don't have the conflict so that composer might decide to install them instead of the latest 6.3.
Instead, what about removing the return type on 7.0 as advised in #51563?

stof · 2023-09-12T09:41:33Z

@nicolas-grekas just removing the return type would fix compat with 7.0. But there is no conflict rule with 8.0 or 9.0 either so this cannot be the proper solution unless we avoid adding that return type forever.
See my proposal in the line comments for a solution that will work properly.

nicolas-grekas · 2023-09-12T09:46:22Z

We bump deps in major version so that this guards naturally against such situations. Also, while we do seek for cross-majors compat between components, we don't between three majors. I would just add the return type in 8.0 and tell ppl that encounter the situation they have to update (6.3 will be EOLed since a long time) since this highly theoretical to me.

stof · 2023-09-12T09:53:12Z

@nicolas-grekas this is a case of an optional dependency between components, for which our existing usages of conflict rules only restrict one side of the range (equivalent to use an optionalRequire on symfony/validator: >= 6.3.1 right now, so unbounded).

nicolas-grekas · 2023-09-12T09:56:19Z

Sure, but still :) combining validator v8 with the bridge v6.3 should be an unsupported situation IMHO so I wouldn't care.

alexander-schranz · 2023-09-12T09:57:17Z

For future we maybe could make sure to add all optional dependencies also to the conflict range to define the supported optional dependency versions. I did that for my search abstraction here: https://github.com/schranz-search/schranz-search/blob/48087364eb6b8b6e147bf475ed5bfb83bf77c88b/integrations/symfony/composer.json#L75-L85. But yeah that is just a solution for future incompatibility, for current I would go with @stof recommendation here if all others are fine with it: #51630 (comment)

nicolas-grekas · 2023-09-12T09:59:36Z

I would go with @stof recommendation

We never do that AFAIK: making a component aware of a bridge (or if we do, that should be exceptionnal). That's broken package principles to me.

stof · 2023-09-12T10:04:29Z

@nicolas-grekas we already made that in the past for conflict rules to handle the fact that we could not retro-actively add an upper bound to an optional dependency that was defined with a conflict rule allowing all future versions.

The way to avoid that (to respect package principles) would be that all our optional dependencies should forbid future major versions of that dependency with a conflict rule until we can ensure compatibility (basically avoiding unbounded optional dependencies)

nicolas-grekas · 2023-09-12T10:14:58Z

That'd be too complex to manage I fear. I'm still up for the simple solution: revert the return type on v7, add it on v8 and don't care about what's going to be theoretical issue in 2/3 years. Alternatively, we could add the conflict in validator v7, but only that then. That's not my preference thought as it "pollutes" the deps of v7, while the point of a major is also to cleanup those things from the past.

derrabus · 2023-09-12T12:17:12Z

src/Symfony/Bridge/Doctrine/composer.json

@@ -63,7 +63,7 @@
        "symfony/proxy-manager-bridge": "<4.4.19",
        "symfony/security-bundle": "<5",
        "symfony/security-core": "<5.3",
-        "symfony/validator": "<5.4.25|>=6,<6.2.12|>=6.3,<6.3.1"
+        "symfony/validator": "<5.4.25|>=6,<6.2.12|>=6.3,<6.3.1,>=7.0"


Suggested change

"symfony/validator": "<5.4.25|>=6,<6.2.12|>=6.3,<6.3.1,>=7.0"

"symfony/validator": "<5.4.25|>=6,<6.2.12|>=6.3,<6.3.1|>=7.0"

nicolas-grekas · 2023-09-12T12:20:29Z

I feel like y'all prefer the conflict-based approach, see #51634

…nicolas-grekas) This PR was merged into the 7.0 branch. Discussion ---------- [Validator] Make v7 conflict with doctrine-bridge < v7 | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Instead of #51630 Commits ------- 6b3e251 [Validator] Make v7 conflict with doctrine-bridge < v7

carsonbot added Status: Needs Review Bug labels Sep 11, 2023

carsonbot added this to the 6.3 milestone Sep 11, 2023

Conflict symfony/validator 7.0 in symfony/doctrine-bridge 6.3

18cdf5f

alexander-schranz changed the base branch from 6.3 to 5.4 September 11, 2023 19:00

alexander-schranz requested review from lyrixx, yceruto, chalasr, dunglas, OskarStark and xabbuh as code owners September 11, 2023 19:00

alexander-schranz force-pushed the patch-11 branch from 0e3cee7 to 18cdf5f Compare September 11, 2023 19:00

alexander-schranz commented Sep 11, 2023

View reviewed changes

alexander-schranz mentioned this pull request Sep 11, 2023

Allow Symfony 7 versions of packages sulu/sulu#7156

Merged

76 tasks

derrabus approved these changes Sep 11, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Sep 11, 2023

derrabus requested changes Sep 12, 2023

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Reviewed labels Sep 12, 2023

nicolas-grekas mentioned this pull request Sep 12, 2023

[Validator] Make v7 conflict with doctrine-bridge < v7 #51634

Merged

nicolas-grekas closed this Sep 12, 2023

alexander-schranz deleted the patch-11 branch September 12, 2023 13:16

alexander-schranz mentioned this pull request May 10, 2024

Symfony 7 compatibililty sulu/sulu#7413

Closed

96 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Conflict symfony/validator 7.0 in symfony/doctrine-bridge 6.3 #51630

Conflict symfony/validator 7.0 in symfony/doctrine-bridge 6.3 #51630

alexander-schranz commented Sep 11, 2023 •

edited

Loading

carsonbot commented Sep 11, 2023

alexander-schranz Sep 11, 2023 •

edited

Loading

stof Sep 12, 2023

alexander-schranz Sep 12, 2023

nicolas-grekas commented Sep 12, 2023

stof commented Sep 12, 2023

nicolas-grekas commented Sep 12, 2023 •

edited

Loading

stof commented Sep 12, 2023

nicolas-grekas commented Sep 12, 2023

alexander-schranz commented Sep 12, 2023

nicolas-grekas commented Sep 12, 2023 •

edited

Loading

stof commented Sep 12, 2023

nicolas-grekas commented Sep 12, 2023 •

edited

Loading

derrabus Sep 12, 2023

nicolas-grekas commented Sep 12, 2023

	"symfony/validator": "<5.4.25\|>=6,<6.2.12\|>=6.3,<6.3.1,>=7.0"
	"symfony/validator": "<5.4.25\|>=6,<6.2.12\|>=6.3,<6.3.1\|>=7.0"

Conflict symfony/validator 7.0 in symfony/doctrine-bridge 6.3 #51630

Conflict symfony/validator 7.0 in symfony/doctrine-bridge 6.3 #51630

Conversation

alexander-schranz commented Sep 11, 2023 • edited Loading

carsonbot commented Sep 11, 2023

alexander-schranz Sep 11, 2023 • edited Loading

Choose a reason for hiding this comment

stof Sep 12, 2023

Choose a reason for hiding this comment

alexander-schranz Sep 12, 2023

Choose a reason for hiding this comment

nicolas-grekas commented Sep 12, 2023

stof commented Sep 12, 2023

nicolas-grekas commented Sep 12, 2023 • edited Loading

stof commented Sep 12, 2023

nicolas-grekas commented Sep 12, 2023

alexander-schranz commented Sep 12, 2023

nicolas-grekas commented Sep 12, 2023 • edited Loading

stof commented Sep 12, 2023

nicolas-grekas commented Sep 12, 2023 • edited Loading

derrabus Sep 12, 2023

Choose a reason for hiding this comment

nicolas-grekas commented Sep 12, 2023

alexander-schranz commented Sep 11, 2023 •

edited

Loading

alexander-schranz Sep 11, 2023 •

edited

Loading

nicolas-grekas commented Sep 12, 2023 •

edited

Loading

nicolas-grekas commented Sep 12, 2023 •

edited

Loading

nicolas-grekas commented Sep 12, 2023 •

edited

Loading