Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conflict symfony/validator 7.0 in symfony/doctrine-bridge 6.3 #51630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexander-schranz wants to merge 1 commit into from
Closed

Conflict symfony/validator 7.0 in symfony/doctrine-bridge 6.3 #51630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Bridge/Doctrine/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"symfony/proxy-manager-bridge": "<4.4.19",
"symfony/security-bundle": "<5",
"symfony/security-core": "<5.3",
"symfony/validator": "<5.4.25|>=6,<6.2.12|>=6.3,<6.3.1"
Copy link
Copy Markdown
Contributor Author

@alexander-schranz alexander-schranz Sep 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it would better to add a conflict to symfony/validator 7.0 as adding a conflict after a release in this case (5.4 and 6.3) will composer maybe just install a old version of the doctrine-bridge e.g. (5.4.28 or 6.3.4) without that conflict and then still run into the same error 🤔.

But it feels strange to add a conflict to symfony/validator as it has not even a optional dependency to the bridge.

Copy link
Copy Markdown
Member

@stof stof Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add this conflict rule here (where it is legitimate), but we should also add it in validator 7.0 to avoid the issue of installing validator 7.0 and an outdated doctrine-bridge.

Copy link
Copy Markdown
Contributor Author

@alexander-schranz alexander-schranz Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would work I think. @nicolas-grekas what do you think about that?

"symfony/validator": "<5.4.25|>=6,<6.2.12|>=6.3,<6.3.1,>=7.0"
Copy link
Copy Markdown
Member

@derrabus derrabus Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"symfony/validator": "<5.4.25|>=6,<6.2.12|>=6.3,<6.3.1,>=7.0"
"symfony/validator": "<5.4.25|>=6,<6.2.12|>=6.3,<6.3.1|>=7.0"

},
"suggest": {
"symfony/form": "",
Expand Down