Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DoctrineBridge] Fix DBAL 4 compatibility #52035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2023
Merged

[DoctrineBridge] Fix DBAL 4 compatibility #52035

merged 1 commit into from
Oct 13, 2023

Conversation

derrabus
Copy link
Member

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT

This PR backports DBAL 4 compatibility changes from #51997 that were not in #51947. Sorry for messing this up.

@carsonbot carsonbot added this to the 6.4 milestone Oct 13, 2023
@carsonbot

This comment was marked as outdated.

Sign in to view
@derrabus derrabus changed the base branch from 6.4 to 5.4 October 13, 2023 09:15
@derrabus derrabus modified the milestones: 6.4, 5.4 Oct 13, 2023
@nicolas-grekas nicolas-grekas changed the title Bugfix/dbal 4 Fix DBAL 4 compatibility Oct 13, 2023
@carsonbot carsonbot changed the title Fix DBAL 4 compatibility [DoctrineBridge] Fix DBAL 4 compatibility Oct 13, 2023
@derrabus derrabus force-pushed the bugfix/dbal-4 branch 3 times, most recently from e6e497e to b7b549e Compare October 13, 2023 09:45
@derrabus
Copy link
Member Author

I've addressed your remarks, @stof.

@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 053b814 into symfony:5.4 Oct 13, 2023
@derrabus derrabus deleted the bugfix/dbal-4 branch October 13, 2023 10:18
@blankse blankse mentioned this pull request Oct 16, 2023
Closed
@fabpot fabpot mentioned this pull request Oct 21, 2023
Merged
@fabpot fabpot mentioned this pull request Oct 29, 2023
Merged
@arderyp
Copy link
Contributor

arderyp commented Mar 5, 2024

@fabpot this issue seems to suggest DBAL 4 is supported as of late October 2023, but a commit you made in February 2024 on symfony/orm-pack suggests that DBAL 4 is not supported: symfony/orm-pack@266bae0

Am I missing something?

@nicolas-grekas
Copy link
Member

See the PR attached to the commit you linked: symfony/orm-pack#43
Symfony is compatible, but not 100% of it, yet.

@stof
Copy link
Member

stof commented Mar 5, 2024

symfony/doctrine-bridge is compatible.
However, symfony/messenger-doctrine is not 100% compatible yet

@arderyp
Copy link
Contributor

arderyp commented Mar 5, 2024 •
edited
Loading

Thanks for the clarifications, I will avoid it for now

@sidz sidz mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@stof stof stof left review comments

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug DoctrineBridge Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@derrabus @carsonbot @nicolas-grekas @arderyp @stof