[Notifier] Add Bluesky notifier bridge #53083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
requested changes
Dec 14, 2023
OskarStark
requested changes
Dec 14, 2023
OskarStark
reviewed
Dec 14, 2023
src/Symfony/Component/Notifier/Bridge/Bluesky/BlueskyTransport.php
Outdated
Show resolved
Hide resolved
fabpot
reviewed
Dec 15, 2023
src/Symfony/Component/Notifier/Bridge/Bluesky/BlueskyTransport.php
Outdated
Show resolved
Hide resolved
fabpot
requested changes
Dec 15, 2023
src/Symfony/Bundle/FrameworkBundle/Resources/config/notifier_transports.php
Outdated
Show resolved
Hide resolved
OskarStark
approved these changes
Dec 15, 2023
|
Thank you for the reviews. I appreciate you finding all my copy-paste issues. |
fabpot
approved these changes
Dec 15, 2023
maxbeckers
approved these changes
Dec 15, 2023
OskarStark
reviewed
Dec 15, 2023
src/Symfony/Bundle/FrameworkBundle/Resources/config/notifier_transports.php
Show resolved
Hide resolved
xabbuh
reviewed
Dec 15, 2023
src/Symfony/Component/Notifier/Bridge/Bluesky/BlueskyTransport.php
Outdated
Show resolved
Hide resolved
xabbuh
approved these changes
Dec 15, 2023
stloyd
reviewed
Dec 15, 2023
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Show resolved
Hide resolved
|
Thank you @Nyholm. |
|
Thank you for merging |
|
Can you create a PR on symfony/recipes @Nyholm ? |
|
Yes. of course. I'll update the docs and a recipe. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would love if Symfony posted their blog posts on https://bsky.app/profile/symfony.bsky.social at some point in the future. I hope this contribution will be a small step towards that.
If someone wants to verify this, I am happy to give out invite codes.
https://bsky.app/profile/nyholm.bsky.social/post/3kgjnhmh4nh2i
I've implemented support for mention and links. Support for images and replies are left outside of the scope for this PR.