[HttpClient] Fix MockResponse in case of header timeout #53625
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f130731 to
2d6c309
Compare
2d6c309 to
a880770
Compare
|
Thanks for submitting. Unless I missed something, this removes the possibility to simulate a timeout immediately after headers have been received, isn't it? new MockResponse('abc', ['error' => new TimeoutException()]);This would define a response that'd behave as if a timeout were reached while sending the request, and that'd resume with the body if the timeout exception is dealt with (by streaming the response again). This would be a new feature of course. |
|
Closing as explained, thanks for submitting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of header timeout - getStatusCode method should throw TimeoutException. That's the expected behaviour for all http client implementations.