Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Workflow] Add support for workflows that need to store many tokens in the marking #54272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2024
Merged

[Workflow] Add support for workflows that need to store many tokens in the marking #54272

merged 1 commit into from
Mar 15, 2024

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Mar 13, 2024

Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #53179
License MIT

@carsonbot carsonbot added this to the 7.1 milestone Mar 13, 2024
@lyrixx lyrixx force-pushed the workflow-multiple-token branch 2 times, most recently from ad2db37 to b990a3a Compare March 13, 2024 15:07
@lyrixx lyrixx requested a review from chalasr March 13, 2024 15:31
nicolas-grekas
nicolas-grekas reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please label the title of the PR as a new feature, since it is?

@lyrixx lyrixx force-pushed the workflow-multiple-token branch from b990a3a to 2221dd0 Compare March 14, 2024 07:58
@lyrixx lyrixx changed the title [Workflow] Fix Marking when it must contains more than one tokens [Workflow] Add support for workflow that need to store many tokens in the marking Mar 14, 2024
@lyrixx lyrixx force-pushed the workflow-multiple-token branch from 2221dd0 to deb8371 Compare March 14, 2024 08:00
@lyrixx
Copy link
Member Author

lyrixx commented Mar 14, 2024

PR updated, thanks

@lyrixx lyrixx force-pushed the workflow-multiple-token branch 2 times, most recently from ce5870f to 98edac5 Compare March 14, 2024 08:04
@lyrixx lyrixx force-pushed the workflow-multiple-token branch from 98edac5 to e698e68 Compare March 14, 2024 08:06
@nicolas-grekas nicolas-grekas changed the title [Workflow] Add support for workflow that need to store many tokens in the marking [Workflow] Add support for workflows that need to store many tokens in the marking Mar 14, 2024
@lyrixx lyrixx force-pushed the workflow-multiple-token branch from e698e68 to 6638497 Compare March 14, 2024 09:05
stof
stof reviewed Mar 14, 2024
View reviewed changes
@lyrixx lyrixx force-pushed the workflow-multiple-token branch from 6638497 to 29158bd Compare March 14, 2024 17:45
@lyrixx
Copy link
Member Author

lyrixx commented Mar 14, 2024

@stof Thanks for the review, I addressed your comments

@stof
Copy link
Member

stof commented Mar 14, 2024

@lyrixx please fix the coding standard issues reported by fabbot (for the exception formatting ones, I think they can be considered false positives)

@lyrixx lyrixx force-pushed the workflow-multiple-token branch from 29158bd to 5b4e9a9 Compare March 14, 2024 18:16
@lyrixx
Copy link
Member Author

lyrixx commented Mar 14, 2024

@stof, thanks, fixed

@lyrixx lyrixx merged commit 83872ca into symfony:7.1 Mar 15, 2024
@lyrixx lyrixx deleted the workflow-multiple-token branch March 26, 2024 07:24
@fabpot fabpot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof approved these changes

@chalasr chalasr Awaiting requested review from chalasr

Assignees
No one assigned
Labels
Bug Status: Reviewed Workflow
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

[Workflow] Verify race condition
4 participants
@lyrixx @stof @nicolas-grekas @carsonbot