Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[PasswordHasher] Skip test assertions that are no longer valid with PHP >= 8.2.18/8.3.5 #54587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2024
Merged

[PasswordHasher] Skip test assertions that are no longer valid with PHP >= 8.2.18/8.3.5 #54587

merged 1 commit into from
Apr 14, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Apr 13, 2024 •
edited
Loading

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

see php/php-src@0ba5229 and https://3v4l.org/9QigI

@xabbuh xabbuh requested a review from chalasr as a code owner April 13, 2024 07:05
@carsonbot carsonbot added this to the 5.4 milestone Apr 13, 2024
@carsonbot carsonbot changed the title [PasswordHasher] fix tests that are no longer valid with PHP >= 8.2.18/8.3.5 [PasswordHasher]  fix tests that are no longer valid with PHP >= 8.2.18/8.3.5 Apr 13, 2024
@xabbuh xabbuh force-pushed the bcrypt-null-password branch from bd08301 to b056298 Compare April 13, 2024 07:49
@xabbuh xabbuh changed the title [PasswordHasher]  fix tests that are no longer valid with PHP >= 8.2.18/8.3.5 [PasswordHasher]  skip tests that are no longer valid with PHP >= 8.2.18/8.3.5 Apr 13, 2024
@xabbuh xabbuh force-pushed the bcrypt-null-password branch from b056298 to d83b619 Compare April 13, 2024 07:50
@xabbuh xabbuh force-pushed the bcrypt-null-password branch 2 times, most recently from 6c1c53e to 20cd73f Compare April 13, 2024 17:56
@xabbuh xabbuh changed the title [PasswordHasher]  skip tests that are no longer valid with PHP >= 8.2.18/8.3.5 [PasswordHasher]  skip test assertions that are no longer valid with PHP >= 8.2.18/8.3.5 Apr 13, 2024
@xabbuh xabbuh force-pushed the bcrypt-null-password branch from 20cd73f to 210e9e4 Compare April 13, 2024 17:57
@xabbuh
Copy link
Member Author

xabbuh commented Apr 13, 2024

I updated the message according to @fabpot's suggestion. While at it I also realised that we shouldn't the skip the whole tests but also a single assertion that no longer works. Inside NativePasswordHasher we already work around the limitation of bcrypt since #40920.

@xabbuh xabbuh requested a review from derrabus April 13, 2024 18:11
@xabbuh xabbuh requested a review from chalasr April 13, 2024 18:11
@OskarStark OskarStark changed the title [PasswordHasher]  skip test assertions that are no longer valid with PHP >= 8.2.18/8.3.5 [PasswordHasher] Skip test assertions that are no longer valid with PHP >= 8.2.18/8.3.5 Apr 13, 2024
@fabpot
Copy link
Member

fabpot commented Apr 14, 2024

Thank you @xabbuh.

@fabpot fabpot merged commit 6a1c9ae into symfony:5.4 Apr 14, 2024
8 of 12 checks passed
@xabbuh xabbuh deleted the bcrypt-null-password branch April 14, 2024 08:01
@xabbuh xabbuh mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@derrabus derrabus derrabus approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
PasswordHasher Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@xabbuh @fabpot @OskarStark @derrabus @chalasr @carsonbot