[AssetMapper] Leverage Filesystem #57890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkunas
reviewed
Jul 31, 2024
smnandre
commented
Jul 31, 2024
src/Symfony/Component/AssetMapper/Tests/ImportMap/RemotePackageStorageTest.php
Outdated
Show resolved
Hide resolved
2ee9657 to
568eb1b
Compare
|
I think all the failures are Mime related |
568eb1b to
fc9308a
Compare
src/Symfony/Component/AssetMapper/ImportMap/RemotePackageStorage.php
Outdated
Show resolved
Hide resolved
|
@nicolas-grekas Used windows-only method to test exception & came back to simpler (not test-related) code in the RemotePackageStorage file AppVeyor had a problem during AssetMapper tests .. Can we re-run them to see ? Unit tests failures unrelated (AssetMapper ones pass) |
OskarStark
reviewed
Aug 16, 2024
src/Symfony/Component/AssetMapper/ImportMap/RemotePackageStorage.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Aug 16, 2024
src/Symfony/Component/AssetMapper/Tests/ImportMap/RemotePackageStorageTest.php
Outdated
Show resolved
Hide resolved
OskarStark
approved these changes
Aug 16, 2024
fabpot
approved these changes
Aug 19, 2024
9b20984 to
a1bb5a2
Compare
|
Thank you @smnandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue the work started in #54173 & #54724 to replace php file functions (
mkdir,file_get_contents,file_put_contents,unlink) by Filesystem methods