Update GitHub PR template #60872
Merged
Update GitHub PR template #60872
+17
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
As I have been removing some deprecated code for 8.0, I was also always wondering how to fill out the table: It is no bug fix, it is no (new) feature, and it is also no deprecation, because it resolves the deprecation. Not sure if you would really somehow include this case to help filling out the table. (Setting everything to "no" also looks "weird" …) |
|
@mttsch that's usually a feature. Signs of feature include need for a changelog line and need for a doc update. Removing (deprecated) features need both. |
da02176 to
40bd9ab
Compare
|
Thank you @javiereguiluz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes: