Update GitHub PR template #60872
Open
Update GitHub PR template #60872
+17
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Comment on lines
+20
to
+21
| - ✨ New features and deprecations must target the **in development** branch | ||
| - 📝 Add a changelog entry: |
There was a problem hiding this comment.
Suggested change
| - ✨ New features and deprecations must target the **in development** branch | |
| - 📝 Add a changelog entry: | |
| - ✨ New features and deprecations must target the **feature** branch | |
| and must add an entry to the changelog file of the patched component: |
There was a problem hiding this comment.
"feature branch" is something that we never mention in Symfony site or docs, so this could be confusing to folks.
We only mention:
- Stable
- LTS
- Maintained
- Unmaintained
- Under development
- Security fixes only
Source: https://symfony.com/releases
There was a problem hiding this comment.
"feature" is the word we use on line 1 of the table, so that might be easier to understand than "in dev", which is not explained in the template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes: