Update GitHub PR template #60872
Update GitHub PR template #60872
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
| - ✨ New features and deprecations must target the **in development** branch | ||
| - 📝 Add a changelog entry: |
There was a problem hiding this comment.
| - ✨ New features and deprecations must target the **in development** branch | |
| - 📝 Add a changelog entry: | |
| - ✨ New features and deprecations must target the **feature** branch | |
| and must add an entry to the changelog file of the patched component: |
There was a problem hiding this comment.
"feature branch" is something that we never mention in Symfony site or docs, so this could be confusing to folks.
We only mention:
- Stable
- LTS
- Maintained
- Unmaintained
- Under development
- Security fixes only
Source: https://symfony.com/releases
There was a problem hiding this comment.
"feature" is the word we use on line 1 of the table, so that might be easier to understand than "in dev", which is not explained in the template
There was a problem hiding this comment.
Don't miss that my suggestion is also about merging the changelog entry suggestion with the feat/deprec line. As is now, people might be confused and think they should add one for bugs too I fear.
|
As I have been removing some deprecated code for 8.0, I was also always wondering how to fill out the table: It is no bug fix, it is no (new) feature, and it is also no deprecation, because it resolves the deprecation. Not sure if you would really somehow include this case to help filling out the table. (Setting everything to "no" also looks "weird" …) |
Proposed changes: