[Translation] Fix handling of empty lines in CsvFileLoader#63064
Merged
nicolas-grekas merged 1 commit intoJan 12, 2026
Merged
Conversation
GromNaN
approved these changes
Jan 12, 2026
1dd8bba to
61a1414
Compare
Member
|
Thank you @fnogatz. |
This was referenced Jan 24, 2026
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In its current version, the
CsvFileLoaderof symfony/translation does not support empty lines within the CSV file due to a missingSplFileObject::DROP_NEW_LINEflag (cf. PHP documentation). Without this change, this would result in a warning like this:This PR changes the test file
resources.csvto contain an empty line, and adds the missing flag inCsvFileLoader::loadResource(). I'm not sure whether this should be handled as a bugfix or new feature. Adding the flag doesn't break backward compatibility.