[Translation] Document empty-$domains behavior on ProviderInterface::read()#64188
Open
ousamabenyounes wants to merge 2 commits into
Open
[Translation] Document empty-$domains behavior on ProviderInterface::read()#64188ousamabenyounes wants to merge 2 commits into
ousamabenyounes wants to merge 2 commits into
Conversation
Member
|
I'd rather decide for a uniform contracts and target 8.2 (8.1 for now, 8.2 when it's branched out) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProviderInterface::read()was undocumented for the empty-$domainscase, and the bundled bridges disagree on the actual behavior:read([], $locales)$domainsforeach ($domains as ...)body is skipped)['*'], returns all domainsRather than unifying these (which would be a BC break on at least Loco), this PR documents the variation in the interface PHPDoc so callers know to pass an explicit domain list for portable behavior.
No runtime change: the docblock edit on
ProviderInterface::read()is the entire diff.