Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Translation] Document empty-$domains behavior on ProviderInterface::read() #64188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ousamabenyounes wants to merge 2 commits into
base: 6.4
Choose a base branch
from
+7 −0
Open

[Translation] Document empty-$domains behavior on ProviderInterface::read() #64188

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acce755
[Translation] Return an empty TranslatorBag when no domains are passe…
ousamabenyounes May 11, 2026
6bb2182
[Translation] Revert LocoProvider runtime change, document provider-s…
ousamabenyounes May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[Translation] Revert LocoProvider runtime change, document provider-s… 
…pecific behavior
  • Loading branch information
@ousamabenyounes
ousamabenyounes committed May 12, 2026
commit 6bb2182e726abfa505dc8df29950eda3d449081a
5 changes: 1 addition & 4 deletions src/Symfony/Component/Translation/Bridge/Loco/LocoProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,9 @@ public function write(TranslatorBagInterface $translatorBag): void

public function read(array $domains, array $locales): TranslatorBag
{
$domains = $domains ?: ['*'];
$translatorBag = new TranslatorBag();

if (!$domains) {
return $translatorBag;
}

foreach ($locales as $locale) {
foreach ($domains as $domain) {
$previousCatalogue = $this->translatorBag?->getCatalogue($locale);
Expand Down
15 changes: 0 additions & 15 deletions src/Symfony/Component/Translation/Bridge/Loco/Tests/LocoProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,21 +1155,6 @@ public static function getResponsesForReadWithLastModified(): \Generator
}
}

public function testReadReturnsEmptyBagWhenNoDomainsAreProvided()
{
$provider = self::createProvider(
new MockHttpClient(function (): ResponseInterface {
$this->fail('No HTTP request should be made when no domains are provided.');
}, 'https://localise.biz/api/'),
$this->getLoader(),
$this->getLogger(),
$this->getDefaultLocale(),
'localise.biz/api/',
);

$this->assertSame([], $provider->read([], ['en'])->getCatalogues());
}

public function testReadForAllDomains()
{
$this->loader = $this->createMock(LoaderInterface::class);
Expand Down
5 changes: 3 additions & 2 deletions src/Symfony/Component/Translation/Provider/ProviderInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@ public function write(TranslatorBagInterface $translatorBag): void;
/**
* Returns translations from the provider for the given $domains and $locales.
*
* If $domains is empty, an empty TranslatorBag is returned: callers that want
* every available domain must pass them explicitly.
* Behavior with an empty $domains array is provider-specific (some return all
* available domains, others return an empty bag); pass an explicit domain list
* for portable results.
*/
public function read(array $domains, array $locales): TranslatorBag;

Expand Down
Loading