[HttpFoundation] fixed the creation of sub-requests under some circumstancies (closes #6923, closes #6936) #6966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stancies (closes symfony#6923, closes symfony#6936) This fixes the creation of a sub-request when the master request Request URI is determined with specific server information.
This was referenced Feb 4, 2013
fabpot
added a commit
that referenced
this pull request
Feb 7, 2013
This PR was merged into the 2.0 branch. Commits ------- ddf4678 [HttpFoundation] fixed the creation of sub-requests under some circumstancies (closes #6923, closes #6936) Discussion ---------- [HttpFoundation] fixed the creation of sub-requests under some circumstancies (closes #6923, closes #6936) | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6923, #6936 | License | MIT | Doc PR | n/a This fixes the creation of a sub-request when the master request Request URI is determined with specific server information.
| } elseif ($this->headers->has('X_REWRITE_URL') && false !== stripos(PHP_OS, 'WIN')) { | ||
| // IIS with ISAPI_Rewrite | ||
| $requestUri = $this->headers->get('X_REWRITE_URL'); | ||
| $this->headers->remove('X_REWRITE_URL'); |
There was a problem hiding this comment.
What if the headers have both X_REWRITE_URL and X_ORIGINAL_URL? Then only one is removed and subrequest could use the wrong request uri again.
There was a problem hiding this comment.
IFAIU, it should not happen as the header is different depending on the server configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the creation of a sub-request when the master request Request URI
is determined with specific server information.