[2.3] [Translator] fixed inconsistency in Translator #7100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Feb 17, 2013
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
| ----- | ||
|
|
||
| * added Translator::getFallbackLocales() | ||
| * deprecated Translator::setFallbackLocale() in favor of the new Translator::setFallbackLocale() method |
There was a problem hiding this comment.
There's an "s" missing at the end: "setFallbackLocale_s_"
|
shouldn't you make |
|
@stof: done |
| * @api | ||
| */ | ||
| public function setFallbackLocale($locales) | ||
| { | ||
| $this->setFallbackLocales(is_array($locales) ? $locales : array($locales)) |
|
shoudn't you also update the place where the method is used (in FrameworkBundle probably) to use the non-deprecated one ? |
fabpot
added a commit
that referenced
this pull request
Mar 6, 2013
This PR was merged into the master branch. Commits ------- 0ef08f5 [Translator] fixed inconsistency in Translator Discussion ---------- [2.3] [Translator] fixed inconsistency in Translator | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a --------------------------------------------------------------------------- by stof at 2013-02-17T20:44:32Z shouldn't you make ``setFallbackLocale`` call ``setFallbackLocales`` ? --------------------------------------------------------------------------- by fabpot at 2013-02-18T14:04:39Z @stof: done --------------------------------------------------------------------------- by stof at 2013-02-18T14:18:10Z shoudn't you also update the place where the method is used (in FrameworkBundle probably) to use the non-deprecated one ?
|
I'm just experiencing an error (BC break?) with these changes. See https://travis-ci.org/craue/TwigExtensionsBundle/builds/5407380 |
fabpot
added a commit
to fabpot/symfony
that referenced
this pull request
Mar 11, 2013
…uration (refs symfony#7100, closes symfony#7315)
fabpot
added a commit
that referenced
this pull request
Mar 11, 2013
This PR was merged into the master branch. Commits ------- 44c8654 [FrameworkBundle] fixed regression for the translator fallback configuration (refs #7100, closes #7315) Discussion ---------- [FrameworkBundle] fixed regression for the translator fallback configuration (refs #7100, closes #7315) | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7315 | License | MIT | Doc PR | n/a --------------------------------------------------------------------------- by craue at 2013-03-11T22:09:35Z :+1:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.