[FrameworkBundle] fixed regression for the translator fallback configuration (refs #7100, closes #7315) #7334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Mar 11, 2013
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #7315 |
| License | MIT |
| Doc PR | n/a |
…uration (refs symfony#7100, closes symfony#7315)
This was referenced Mar 11, 2013
|
👍 |
fabpot
added a commit
that referenced
this pull request
Mar 11, 2013
This PR was merged into the master branch. Commits ------- 44c8654 [FrameworkBundle] fixed regression for the translator fallback configuration (refs #7100, closes #7315) Discussion ---------- [FrameworkBundle] fixed regression for the translator fallback configuration (refs #7100, closes #7315) | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7315 | License | MIT | Doc PR | n/a --------------------------------------------------------------------------- by craue at 2013-03-11T22:09:35Z :+1:
| @@ -533,6 +533,9 @@ private function registerTranslatorConfiguration(array $config, ContainerBuilder | |||
| // Use the "real" translator instead of the identity default | |||
| $container->setAlias('translator', 'translator.default'); | |||
| $translator = $container->findDefinition('translator.default'); | |||
| if (!is_array($config['fallback'])) { | |||
| $config['fallback'] = array($config['fallback']); | |||
There was a problem hiding this comment.
shouldn't you move this to the Configuration class instead ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.