[2.2][Process] Fix Array to string conversion exception #7354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added relative path canonicalization according to RFC 3986, section 5.2.4
schemes and methods may also be delimited by whitespace, comma or pipe. this eases migration as now schemes="GET|POST" also works
This PR was squashed before being merged into the 2.1 branch (closes #7260). Commits ------- 1d3da29 [FrameworkBundle] avoids cache:clear to break if new/old folders already exist Discussion ---------- [FrameworkBundle] avoids cache:clear to break if new/old folders already exist | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6502 --------------------------------------------------------------------------- by mahmouds at 2013-03-04T19:07:20Z :+1:
This PR was merged into the 2.1 branch. Commits ------- a4ec677 [DomCrawler] Fix relative path handling in links Discussion ---------- [2.1][DomCrawler] Fix relative path handling in links | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7219 | License | MIT | Doc PR | n/a Added relative path canonicalization according to RFC 3986, section 5.2.4 --------------------------------------------------------------------------- by vicb at 2013-03-02T14:48:46Z @fabpot seems like 2.1 as a deps issue if you look at travis logs
Fixes INF problem on solaris.
This PR was merged into the 2.2 branch. Commits ------- 54c333d [Routing] unify and fix the loader tests 41ad9d8 [Routing] make xml loader more tolerant Discussion ---------- [Routing] make xml loader more tolerant schemes and methods may also be delimited by whitespace, comma or pipe. Fixes #6049 (comment) this eases migration as now `methods="GET|POST"` also works the second commit unifies the tests and fixes some strange assertions that were useless | Q | A | ------------- | --- | Bug fix? | [yes] | New feature? | [yes but not really] | BC breaks? | [no] | Deprecations? | [no] | Tests pass? | [yes] | License | MIT
This PR was merged into the 2.2 branch. Commits ------- a59e5e4 [Finder] Unified tests Discussion ---------- [Finder] Unified tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Tests for `Finder` are very difficult to read because they contain calls to: sys_get_temp_dir() . '/symfony2_finder/' This improved version simplifies adding and removing new dirs and files.
Fix "Warning: Missing argument 3" for XmlEncoder::buildXml() called several times in XmlEncoder::selectNodeType()
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #7292). Commits ------- 4ffe234 Fix warning for buildXml method Discussion ---------- Fix missing argument This PR was submitted on the symfony/Serializer read-only repository and moved automatically to the main Symfony repository (closes symfony/serializer#4). Fix "Warning: Missing argument 3" for XmlEncoder::buildXml() called several times in XmlEncoder::selectNodeType()
Fixed test to use Reflection
This PR was merged into the 2.1 branch. Commits ------- 27cc0df Merge pull request #1 from merk/class-loader/idempotent 95af84c Fixed test to use Reflection bb08247 [ClassLoader] tweaked test 73bead7 [ClassLoader] made DebugClassLoader idempotent Discussion ---------- [ClassLoader] made DebugClassLoader idempotent The DebugClassLoader will wrap itself if `enable()` is called multiple time, such as when running functional tests. Please merge to 2.2 and master ASAP. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ --------------------------------------------------------------------------- by kriswallsmith at 2013-03-07T16:38:55Z ping @fabpot: this will speed up lots of functional tests :) --------------------------------------------------------------------------- by kriswallsmith at 2013-03-08T04:51:51Z @fabpot fixed by @merk
- use dedicated Route:getMethods, getSchemes - pattern -> path - show missing scheme requirement - show missing host regex - refactoring
This PR was merged into the 2.2 branch. Commits ------- 15bf033 [FrameworkBundle] fix router debug command d16d193 [FramworkBundle] removed unused property of trans update command 5361f83 [FramworkBundle] fix phpdoc of commands Discussion ---------- [FrameworkBundle] router debug command fix | Q | A | ------------- | --- | Bug fix? | [yes] | New feature? | [no] | BC breaks? | [no] | Deprecations? | [no] | Tests pass? | [yes] | License | MIT See commits.
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #7302). Commits ------- 3f3cf0c fix xargs pipe to work with spaces in dir names Discussion ---------- [Finder] fix xargs pipe to work with spaces in dir names | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT .. otherwise grep fails: ```` grep: : No such file or directory grep: /Users/havvg/Web: No such file or directory grep: Development/symfony2/src/Symfony/Component/Finder/Tests/Fixtures/dolor.txt: No such file or directory ```
This PR was merged into the 2.1 branch. Commits ------- 547350c [FrameworkBundle] Fix code status in dockblock Discussion ---------- [FrameworkBundle] Fixed code status in docblock | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | --------------------------------------------------------------------------- by Tobion at 2013-03-09T15:23:46Z :+1:
* 2.1: [FrameworkBundle] Fix code status in dockblock Fixed test to use Reflection [Finder] fixed a potential issue on Solaris where INF value is wrong (refs #7269) Update RouteCompiler.php [FrameworkBundle] avoids cache:clear to break if new/old folders already exist [HttpKernel] Fixed possible profiler token collision (closes #7272, closes #7171) [ClassLoader] tweaked test [ClassLoader] made DebugClassLoader idempotent [DomCrawler] Fix relative path handling in links Conflicts: src/Symfony/Component/DomCrawler/Link.php src/Symfony/Component/Finder/Iterator/DepthRangeFilterIterator.php src/Symfony/Component/Routing/RouteCompiler.php
This PR was merged into the 2.2 branch. Commits ------- a735cbd fix xargs pipe to work with spaces in dir names Discussion ---------- [Finder] fix xargs pipe to work with spaces in dir names | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT .. otherwise grep fails: ```` grep: : No such file or directory grep: /Users/havvg/Web: No such file or directory grep: Development/symfony2/src/Symfony/Component/Finder/Tests/Fixtures/dolor.txt: No such file or directory ```
This PR was squashed before being merged into the 2.2 branch (closes #7321). Commits ------- 4f3771d [2.2][HttpKernel] fixed wrong option name in FragmentHandler::fixOptions Discussion ---------- [2.2][HttpKernel] fixed wrong option name in FragmentHandler::fixOptions | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7309 --------------------------------------------------------------------------- by Aitboudad at 2013-03-10T11:38:59Z Hi @fabpot, can you see why all commits has failed on Travis ? --------------------------------------------------------------------------- by henrikbjorn at 2013-03-10T11:42:25Z The test expects the option to be called `renderer` and not `strategy` so you need to change the tests. --------------------------------------------------------------------------- by Aitboudad at 2013-03-10T12:19:19Z @henrikbjorn thanks it's ok, but there is still 1 test :( in Symfony\Component\Form\Tests\Extension\Core\Type\TimeTypeTest::testSetDataDifferentTimezones @bschussek Can you see why :).
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #7320). Commits ------- 7ff2d52 Property accessor custom array object fix Discussion ---------- Property accessor custom array object fix Copied `Symfony\Component\Form\Tests\Fixtures\CustomArrayObject` to Fixtures dir, and used it in tests to be able run tests separately from Form component,
fixed annotations
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #7333). Commits ------- 6992a9e [DependencyInjection] fixed id case when setting a service (also slightly enhanced an error message) Discussion ---------- [DependencyInjection] fixed id case when setting a service (also slightly enhanced an error message) | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a
|
It is the user responsibility to pass a key/value array with only strings for values. |
|
Thanks for following up, Fabien. I do disagree due to the way ProcessBuilder uses $_ENV which is then passed It is the user responsibility to pass a key/value array with only strings
|
This was referenced May 17, 2013
egeloen
pushed a commit
to egeloen/symfony
that referenced
this pull request
Nov 4, 2013
There are cases where $env or $_ENV can contain a value that is an array This will cause Process to throw an Array to String conversion exception Initially I submitted a patch of Process.php, however Fabien indicated that it shouldn't be fixed there (see below pull request). Before recently, a simple work around would be in php.ini to set: register_argc_argv = On However with recent changes, this seems to no longer work. Original pull request: symfony#7354 See ticket symfony#7196
egeloen
pushed a commit
to egeloen/symfony
that referenced
this pull request
Nov 4, 2013
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes symfony#8227). Discussion ---------- [Process] fix issue where $_ENV contains array vals There are cases where $env or $_ENV can contain a value that is an array This will cause Process to throw an Array to String conversion exception Initially I submitted a patch of Process.php, however Fabien indicated that it shouldn't be fixed there (see below pull request). Before recently, a simple work around would be in php.ini to set: register_argc_argv = On However with recent changes, this seems to no longer work. Original pull request: symfony#7354 See ticket symfony#7196 ``` | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | 7196 | License | MIT | Doc PR | none ``` Commits ------- 2c6af95 [Process] fix issue where $_ENV contains array vals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where env actually contains values that are arrays
#7353