[TwigBundle] Adds service check for extension loading #7373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $container->getDefinition('twig.loader')->addMethodCall('addPath', array(dirname(dirname($reflClass->getFileName())).'/Resources/views/Form')); | ||
| } | ||
|
|
||
| if (false === $container->has('translator')) { |
There was a problem hiding this comment.
This looks weird to me. Adding the tag when it does not have the translator ?
There was a problem hiding this comment.
I think it's a rebase error.
There was a problem hiding this comment.
fixed in #7373, thanks!
|
This should also be done for the fragment handler for |
Merged
fabpot
added a commit
that referenced
this pull request
Mar 14, 2013
This PR was merged into the master branch. Commits ------- 82aa135 [TwigBundle] added conditions for routing & httpkernel extensions ad5eb7e [TwigBundle] fixed compiler pass error Discussion ---------- Issue 7373 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7373
jfsimon
added a commit
to jfsimon/symfony
that referenced
this pull request
Mar 15, 2013
fabpot
added a commit
that referenced
this pull request
Mar 16, 2013
This PR was merged into the master branch. Commits ------- 6021873 [TwigBundle] fixed wrong rebase in #7373 Discussion ---------- [TwigBundle] fixed wrong rebase in #7375 When rebasing on master, `twig.loader` has not been renamed to `twig.loader.filesystem`. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7375 --------------------------------------------------------------------------- by stof at 2013-03-15T16:48:44Z :+1:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds following checks:
twig.extension.formextension is loaded ifform.extensionservice is definedtwig.extension.transextension is loaded iftranslatorservice is defined