Issue 7373 #7375
Merged
Issue 7373 #7375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jfsimon
commented
Mar 14, 2013
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #7373 |
fabpot
added a commit
that referenced
this pull request
Mar 14, 2013
This PR was merged into the master branch. Commits ------- 82aa135 [TwigBundle] added conditions for routing & httpkernel extensions ad5eb7e [TwigBundle] fixed compiler pass error Discussion ---------- Issue 7373 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7373
| $container->getDefinition('twig.extension.trans')->addTag('twig.extension'); | ||
| } | ||
|
|
||
| if ($container->has('router')) { | ||
| $container->getDefinition('twig.extension.routing')->addTag('twig.extension'); |
There was a problem hiding this comment.
I don't know if it's possible or better. But I think adding a tag in the compiler pass is strange and counter-intuitive.
Would it not be better to remove the definition of the service when the service cannot be used? Like
$container->removeDefinition('twig.extension.routing')?
There was a problem hiding this comment.
In the first place, I loaded service definition (with separate XMLs) only if dependencies were satisfied. Then @stof told me to do it this way because "it avoids breaking other compiler passes trying to access the extension".
fabpot
added a commit
that referenced
this pull request
Mar 16, 2013
This PR was merged into the master branch. Commits ------- 6021873 [TwigBundle] fixed wrong rebase in #7373 Discussion ---------- [TwigBundle] fixed wrong rebase in #7375 When rebasing on master, `twig.loader` has not been renamed to `twig.loader.filesystem`. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7375 --------------------------------------------------------------------------- by stof at 2013-03-15T16:48:44Z :+1:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.