[Console] ensure integer exit codes in events #8038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tobion
commented
May 14, 2013
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| License | MIT |
| @@ -131,7 +131,7 @@ public function run(InputInterface $input = null, OutputInterface $output = null | |||
| } | |||
| $exitCode = $e->getCode(); | |||
|
|
|||
| $exitCode = is_numeric($exitCode) && $exitCode ? $exitCode : 1; | |||
| $exitCode = $exitCode ? (is_numeric($exitCode) ? (int) $exitCode : 1) : 0; | |||
There was a problem hiding this comment.
This previously considered null and '' as an error which is not intented.
|
Seems reasonable to me. |
|
Looks good to me. We probably need to add tests for the edge cases and I think it should be done on the 2.1 branch instead. |
fabpot
added a commit
that referenced
this pull request
May 19, 2013
This PR was merged into the master branch. Discussion ---------- [Console] ensure integer exit codes in events | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Commits ------- fe1db71 [Console] ensure integer exit codes in events
fabpot
added a commit
that referenced
this pull request
May 19, 2013
|
@fabpot not 2.3? |
|
sorry, I forgot to switch the target. fixed now. |
|
@fabpot seems like you didn't merge it in 2.3. It still not there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.