Allow TemplateManager to fallback to SF TemplateNameParser & TemplateLocator #8667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests fail but it seems they fail for master too. The last build still used twig 0e63ef04a00fb238ee457708f8b4e8918aa51d7e. |
|
It’s actually the FilesystemLoader that’s broken so I’m closing this in favour of #8672. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
existmethod of theSymfony\Bundle\TwigBundle\Loader\FilesystemLoader(inherited fromTwig_Loader_Filesystem) doesn’t fallback to Symfony’s TemplateNameParser & TemplateLocator and therefore fails on template names following the Bundle syntax likeSecurityBundle:Collector:security.This is option 1 how to fix this. However, I prefer option 2..see #8266.