[TwigBundle] made the filesystem loader compatible with Twig 2.0 #8677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without adding the exists() method, the code happens to work by chance, just because the current implementation of Twig exits() method calls findTemplate(). But we know that it won't be the case anymore as of Twig 2.0.
|
The unit test does not pass if using Twig 2.0 and without adding the exists() method. |
|
👍 I thought this would be rejected because of duplication of code (try..catch) but it seems to be the only choice here if compatibility with all Twig versions needs to be preserved. |
fabpot
added a commit
that referenced
this pull request
Aug 8, 2013
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #8677). Discussion ---------- [TwigBundle] made the filesystem loader compatible with Twig 2.0 | Q | A | ------------- | --- | Bug fix? | yes (for Twig 2.x) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Without adding the exists() method, the code happens to work by chance, just because the current implementation of Twig exits() method calls findTemplate(). But we know that it won't be the case anymore as of Twig 2.0. Commits ------- d00548b [TwigBundle] made the filesystem loader compatible with Twig 2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without adding the exists() method, the code happens to work by chance,
just because the current implementation of Twig exits() method calls
findTemplate().
But we know that it won't be the case anymore as of Twig 2.0.