Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Console] Improved xml generated when listing commands #8928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Console] Improved xml generated when listing commands #8928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
734fec1
Renamed symfony node on list --xml command to current application nam…
deguif Sep 4, 2013
e8ec093
Fixed tests
deguif Sep 4, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Symfony/Component/Console/Descriptor/XmlDescriptor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,15 @@ public function getCommandDocument(Command $command)
public function getApplicationDocument(Application $application, $namespace = null)
{
$dom = new \DOMDocument('1.0', 'UTF-8');
$dom->appendChild($rootXml = $dom->createElement('symfony'));
$dom->appendChild($rootXml = $dom->createElement('application'));

if ($application->getName() !== 'UNKNOWN') {
$rootXml->setAttribute('name', $application->getName());
if ($application->getVersion() !== 'UNKNOWN') {
$rootXml->setAttribute('version', $application->getVersion());
}
}

$rootXml->appendChild($commandsXML = $dom->createElement('commands'));

$description = new ApplicationDescription($application, $namespace);
Expand Down
4 changes: 2 additions & 2 deletions src/Symfony/Component/Console/Tests/Fixtures/application_1.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<symfony>
<application>
<commands>
<command id="help" name="help">
<usage>help [--xml] [--format="..."] [--raw] [command_name]</usage>
Expand Down Expand Up @@ -105,4 +105,4 @@
<command>list</command>
</namespace>
</namespaces>
</symfony>
</application>
4 changes: 2 additions & 2 deletions src/Symfony/Component/Console/Tests/Fixtures/application_2.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<symfony>
<application name="My Symfony application" version="v1.0">
<commands>
<command id="help" name="help">
<usage>help [--xml] [--format="..."] [--raw] [command_name]</usage>
Expand Down Expand Up @@ -182,4 +182,4 @@
<command>descriptor:command2</command>
</namespace>
</namespaces>
</symfony>
</application>
4 changes: 2 additions & 2 deletions src/Symfony/Component/Console/Tests/Fixtures/application_asxml1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<symfony>
<application>
<commands>
<command id="help" name="help">
<usage>help [--xml] [--format="..."] [--raw] [command_name]</usage>
Expand Down Expand Up @@ -141,4 +141,4 @@
<command>foo:bar</command>
</namespace>
</namespaces>
</symfony>
</application>
4 changes: 2 additions & 2 deletions src/Symfony/Component/Console/Tests/Fixtures/application_asxml2.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<symfony>
<application>
<commands namespace="foo">
<command id="foo:bar" name="foo:bar">
<usage>foo:bar</usage>
Expand Down Expand Up @@ -34,4 +34,4 @@
</options>
</command>
</commands>
</symfony>
</application>