Removed observer pattern, in favour of mediator #9661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Nov 30, 2013
This PR was merged into the 2.2 branch. Discussion ---------- Removed observer pattern, in favour of mediator | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | * | Fixed tickets | #9344 I don't think this is the best tool to implement the observer pattern. I just have copied the sentence from: https://github.com/symfony/symfony-docs/edit/2.3/components/event_dispatcher/introduction.rst but maybe could be improved with something like: "Symfony Event Dispatcher is a tool that allows to make your projects truly extensible, facilitating the implementation of Mediator pattern and Publish subscribe pattern" [edit-1] I think this could be modified also here: https://github.com/symfony/symfony-marketing/edit/master/views/en/get_started/components.html.twig Commits ------- ab3e231 [EventDispatcher] tweaked README b9ad62e removed observer pattern, in favour of mediator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is the best tool to implement the observer pattern.
I just have copied the sentence from:
https://github.com/symfony/symfony-docs/edit/2.3/components/event_dispatcher/introduction.rst
but maybe could be improved with something like:
"Symfony Event Dispatcher is a tool that allows to make your projects truly extensible, facilitating the implementation of Mediator pattern and Publish subscribe pattern"
[edit-1]
I think this could be modified also here:
https://github.com/symfony/symfony-marketing/edit/master/views/en/get_started/components.html.twig