Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Debug] New @method detection #10504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ro0NL opened this issue Oct 17, 2018 · 0 comments
Closed

[Debug] New @method detection #10504

ro0NL opened this issue Oct 17, 2018 · 0 comments
Labels
Debug

Comments

@ro0NL
Copy link
Contributor

ro0NL commented Oct 17, 2018 •
edited
Loading

See symfony/symfony#28902

Basically enables adding methods to interfaces in an upcoming major. Not declaring real methods for @method annotations will trigger a deprecation in the current major.

  • the vendor should depend on a method_exists() check in the current major, providing a fallback in case the consumer object is not yet upgraded
  • the vendor should declare the real interface method in the upcoming major, removing the @method annotation and method_exists check at this point
  • the consumer should fix deprecation before upgrading, not doing so will hard cause a hard crash due the above changes by the vendor

I think it should be added to https://symfony.com/bc also

The detected signature, per phpdoc3, is:

@method [[static] return type] [name]([[type] [parameter]<, ...>]) [<description>]
@ro0NL ro0NL mentioned this issue Oct 17, 2018
Merged
@javiereguiluz javiereguiluz added Debug Waiting Code Merge Docs for features pending to be merged labels Oct 18, 2018
@fabpot fabpot removed the Waiting Code Merge Docs for features pending to be merged label Jan 5, 2019
symfony-splitter pushed a commit to symfony/debug that referenced this issue Jan 5, 2019
@fabpot
feature #28902 [Debug] Detect virtual methods using @method (ro0NL)
b04503a 
This PR was squashed before being merged into the 4.3-dev branch (closes #28902).

Discussion
----------

[Debug] Detect virtual methods using @method

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | symfony/symfony#28897 (comment)
| License       | MIT
| Doc PR        | symfony/symfony-docs#10504

My first Debug PR, so im still on it. But early feedback welcome.

In #28901 we'll introduce a new virtual interface method using `@method` annotation. IIUC the idea is to trigger whenever such a method is overridden.

Commits
-------

38877c32ac [Debug] Detect virtual methods using @method
fabpot added a commit to symfony/symfony that referenced this issue Jan 5, 2019
@fabpot
feature #28902 [Debug] Detect virtual methods using @method (ro0NL)
5c2cee5 
This PR was squashed before being merged into the 4.3-dev branch (closes #28902).

Discussion
----------

[Debug] Detect virtual methods using @method

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #28897 (comment)
| License       | MIT
| Doc PR        | symfony/symfony-docs#10504

My first Debug PR, so im still on it. But early feedback welcome.

In #28901 we'll introduce a new virtual interface method using `@method` annotation. IIUC the idea is to trigger whenever such a method is overridden.

Commits
-------

38877c3 [Debug] Detect virtual methods using @method
@ro0NL ro0NL mentioned this issue Apr 2, 2020
Merged
@ro0NL ro0NL closed this as completed Oct 4, 2020
@ro0NL ro0NL mentioned this issue Feb 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Debug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @javiereguiluz @ro0NL