[Form] Bootstrap 5 documentation #15158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-richard
suggested changes
Mar 28, 2021
|
Thank you @t-richard for your review ! |
OskarStark
reviewed
Apr 1, 2021
|
Romain, thanks for this contribution! We'll need to wait until the code PR is merged ... that will need to wait until Bootstrap 5 is released as stable. When this happens, we'll need to reevaluate if we add this new doc article or transform the existing "bootstrap4" doc article into a generic article about all Bootstrap versions. We'll probably do that if differences between versions are not many, because that makes things easier for readers. Thanks. |
e3fac90 to
80c3549
Compare
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
May 6, 2021
This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [TwigBridge] Add form templates for Bootstrap 5 | Q | A | ------------- | --- | Branch | 5.x | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | [#15158](symfony/symfony-docs#15158) This PR add support for [Bootstrap 5](https://v5.getbootstrap.com/) * Removal of the `form-group` class as it no longer exists in Bootstrap 5. Instead, row `div` have a `mb-3` class by default that can be override with the `row_attr` option. * Errors are no longer display inside `label` but after the `widget` (or `help` if present). * Replace `form-control` with `form-select` in `choice_widget_collapsed` block. * Replace `form-control` with `form-range` in `form_widget_simple` block when the type is `range`. * Add `form-control-color` to the `widget` class if type is `color`. * Replace `small` with `div` element for `help` and also remove the `text-muted` class. * Update the `percent_widget` and `money_widget` to handle correctly prepend and append elements. * Drop support for custom file input as it's no longer (or yet ?) supported in Bootstrap 5 [Bootstrap 5 forms overview](https://v5.getbootstrap.com/docs/5.0/forms/overview/) [Bootstrap 5 migration](https://v5.getbootstrap.com/docs/5.0/migration/) Here is the result:   Commits ------- d52d096 [TwigBridge] Add form templates for Bootstrap 5
|
Hello @javiereguiluz Now that the code PR has been merged and the release of 5.3 is coming, have you any feed back regarding this PR ? |
80c3549 to
bcaf46a
Compare
|
Romain, thanks for the ping! After thinking about this, I've merged your PR "as is". There are some differences between Bootstrap 4 and 5, so it might be more clear for the reader to separate them. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce documentation for Bootstrap 5 form template