Thanks to visit codestin.com
Credit goes to github.com

Skip to content

match parameter names with AbstractBundle #19321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2024
Merged

match parameter names with AbstractBundle #19321

merged 1 commit into from
Jan 17, 2024

Conversation

tacman
Copy link
Contributor

@tacman tacman commented Dec 20, 2023

For consistency, the parameters should match AbstractBundle

@javiereguiluz javiereguiluz added this to the 6.3 milestone Jan 17, 2024
@javiereguiluz javiereguiluz changed the base branch from 7.0 to 6.3 January 17, 2024 13:49
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner January 17, 2024 13:49
@javiereguiluz
Copy link
Member

Good catch, thanks Tac.

@javiereguiluz javiereguiluz merged commit 97b5ef1 into symfony:6.3 Jan 17, 2024
@tacman tacman deleted the patch-23 branch January 17, 2024 13:56
@xabbuh xabbuh mentioned this pull request Jan 18, 2024
Merged
xabbuh added a commit that referenced this pull request Jan 18, 2024
@xabbuh
minor #19438 Revert "match parameter names with AbstractBundle" (xabbuh)
8ac82c9 
This PR was merged into the 6.3 branch.

Discussion
----------

Revert "match parameter names with AbstractBundle"

This reverts commit 6896b7e.

reverting #19321 to make the CI green again

Commits
-------

63b32b5 Revert "match parameter names with AbstractBundle"
@xabbuh
Copy link
Member

xabbuh commented Jan 18, 2024

FYI, I have reverted this PR as it breaks our CI (see #19438)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@tacman @javiereguiluz @xabbuh @carsonbot