-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Javiereguiluz revamped quick tour #3613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g Picture" chapter
added a section about displaying error pages
and try to execute the server:run command
This was referenced Feb 26, 2014
About the version: What about using the LTS? |
@wouterj that's an interesting idea. Regardless, I think the best would be to be consistent with symfony.com/download (which will be changing shortly). We can obviously tweak this later - I'm going to merge for now and we'll keep figuring that part out. |
weaverryan
added a commit
that referenced
this pull request
Feb 27, 2014
This PR was merged into the 2.3 branch. Discussion ---------- Javiereguiluz revamped quick tour Hey guys! See #3562 - this is the same, but rebased against the 2.3 branch. | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | 2.3+ | Fixed tickets | Off of the top of my head (but I could be wrong), the only thing that was 2.4 specific is the version number used in the composer.phar create-project command. We could fix this in 2 different ways: 1) Don't fix it - just always keep that number updated to the latest released version. We do this similarly in other places 2) Use "@stable" as the version constraint. I don't know of any drawbacks. Thanks! Commits ------- 1e36cfa [quick_tour] rewording and grammar fixes noted by @xabbuh 69fdff1 [quick_tour] removed an unneeded comma 30624eb [quick_tour] more rewording and grammar fixes 0f13ce9 [quick_tour] rewording and grammar fixes suggested by @weaverryan 7c0037e Restored all the original introductions for each tutorial part cb98a6c Restored the original line that explained how a routing file is imported from a bundle fdc755e Grammar fixes proposed by @weaverryan and @wouterj eca1e73 Added a more useful message for users that don't have PHP 5.4 and try to execute the server:run command a013b11 Removed the animated GIF showing how to install Symfony 985c68f Replaced "variable" by "placeholder" when using {_format} inside a route 42bd69f Fixed the capitalization of a section heading 75be815 Minor rewording c1ad15d Added a new headline to better structure the documentation b16c3a2 Capitalized some sentences that come after a colon 2fdcffd When using server:run command, it's not necessary to add the `app_dev.php` controller 6afc80b Removed a wrongly inserted comma e004661 Bundle names should not be placed in literals 38b1292 [quick_tour] removed inline links 81d6e20 [quick_tour] replaced "chapter" by "part" in some tutorial parts 50e136c [quick_tour] second pass to "the architecture" chapter cdb7064 [quick_tour] second pass to "the controller" chapter and added a section about displaying error pages 2cd3bab [quick tour] second pass to "the view" chapter 4ad3c44 [quick_tour] second pass to the "big picture" chapter e7dfc8b [quick_tour] simplified "the architecture" chapter eb3fe4c [quick tour] simplified "the controller" chapter dbbc8c2 [quick_tour] updated "the view" chapter 5b3a572 [quick_tour] finished the review of "The Big Picture" chapter f24eabc [quick_tour] updated some screenshots 20e9fb0 [quick_tour] updated the "Controllers" section 29992cd [quick_tour] simplified the "routing" section a84a556 [quick_tour] simplified drastically the first two sections of "The Big Picture" chapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys!
See #3562 - this is the same, but rebased against the 2.3 branch.
Off of the top of my head (but I could be wrong), the only thing that was 2.4 specific is the version number used in the composer.phar create-project command. We could fix this in 2 different ways:
Don't fix it - just always keep that number updated to the latest released version. We do this similarly in other places
Use "@stable" as the version constraint. I don't know of any drawbacks.
Thanks!