-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[WIP] Add doc for tel type #4040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lepiaf
commented
Jul 20, 2014
Q | A |
---|---|
Doc fix? | no |
New docs? | yes symfony/symfony#11360 |
Applies to | all (or 2.3+) |
Fixed tickets | symfony/symfony#8026 |
.. index:: | ||
single: Forms; Fields; tel | ||
|
||
tel Field Type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"tel" should be capitialized (Tel
)
Thanks for submitting! You should add references to this file in And you should add a Tel Field Type
==============
.. versionadded:: 2.7
The Tel field type was introduced in Symfony 2.7. |
I don't know if it is really in 2.7. How can know it? |
Well, it can't go into anything lower than 2.7, so I would recommend to just assume it's going into 2.7 and update this PR if it turns out it is going to be in another version. |
Where should I put a reference to this file in |
@wouterj Why 2.7 and not 2.6? |
I think @wouterj meant |
Should we specify in the documentation, that the component rely on a third party library (https://github.com/giggsey/libphonenumber-for-php) to validat phone numbers? |
indeed, good one @jeremy-derusse @lepiaf as said by jeremy, you should add a |
@@ -0,0 +1,107 @@ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be PhoneNumber, shouldn't it?
@wouterj should be closed as the code PR has been rejected |
@stof thanks,thought it was merged |