Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP] Add doc for tel type #4040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[WIP] Add doc for tel type #4040

wants to merge 6 commits into from

Conversation

lepiaf
Copy link
Contributor

@lepiaf lepiaf commented Jul 20, 2014

Q A
Doc fix? no
New docs? yes symfony/symfony#11360
Applies to all (or 2.3+)
Fixed tickets symfony/symfony#8026

.. index::
single: Forms; Fields; tel

tel Field Type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"tel" should be capitialized (Tel)

@wouterj
Copy link
Member

wouterj commented Jul 20, 2014

Thanks for submitting!

You should add references to this file in reference/forms/types.rst and reference/index.rst.

And you should add a versionadded directive saying that this is new:

Tel Field Type
==============

.. versionadded:: 2.7
    The Tel field type was introduced in Symfony 2.7.

@lepiaf
Copy link
Contributor Author

lepiaf commented Jul 20, 2014

I don't know if it is really in 2.7. How can know it?

@wouterj
Copy link
Member

wouterj commented Jul 20, 2014

Well, it can't go into anything lower than 2.7, so I would recommend to just assume it's going into 2.7 and update this PR if it turns out it is going to be in another version.

@lepiaf
Copy link
Contributor Author

lepiaf commented Jul 20, 2014

Where should I put a reference to this file in reference/index.rst ? It does not list all type of field.

@xabbuh
Copy link
Member

xabbuh commented Jul 20, 2014

@wouterj Why 2.7 and not 2.6?

@xabbuh
Copy link
Member

xabbuh commented Jul 20, 2014

Where should I put a reference to this file in reference/index.rst ? It does not list all type of field.

I think @wouterj meant /reference/forms/types/map.rst.inc.

@wouterj
Copy link
Member

wouterj commented Jul 20, 2014

I think @wouterj meant /reference/forms/types/map.rst.inc.

Yes

@wouterj Why 2.7 and not 2.6?

Oh, sorry @lepiaf it should be 2.6 then. After 2 weeks on holiday, I forgot the latest stable version...

@jderusse
Copy link
Member

Should we specify in the documentation, that the component rely on a third party library (https://github.com/giggsey/libphonenumber-for-php) to validat phone numbers?

@wouterj
Copy link
Member

wouterj commented Jul 20, 2014

indeed, good one @jeremy-derusse

@lepiaf as said by jeremy, you should add a .. note:: directive saying that it relies on a third party library and that you need to require + install it using Composer before you can use the constraint.

@@ -0,0 +1,107 @@
Email
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be PhoneNumber, shouldn't it?

@stof
Copy link
Member

stof commented Sep 16, 2014

@wouterj should be closed as the code PR has been rejected

@wouterj wouterj closed this Sep 16, 2014
@wouterj
Copy link
Member

wouterj commented Sep 16, 2014

@stof thanks,thought it was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants