-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Fix YAML config bug #8987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix YAML config bug #8987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be merged into all version branches
Can you explain why you think that this is wrong? |
Oh! I might see it. The YAML is correct. But the XML and PHP don't match up with the YAML. The XML and PHP versions are what need to be updated :) |
javiereguiluz
approved these changes
Jan 7, 2018
Thanks @Holicz. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 7, 2018
xabbuh
pushed a commit
that referenced
this pull request
Jan 8, 2018
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Jan 10, 2018
* 3.3: (22 commits) add note about same-state transitions minor symfony#8205 Move JavaScript to separate file (technetium, javiereguiluz) [error_pages] Removing misleading checker in code example Updated LDAP documentation for Symfony 3.1 Updating example README to match note below it Update docs for setting custom response code in exception handler add default option value for collection type minor symfony#8831 Update collection.rst (babaorum) minor symfony#8987 Fix YAML config bug (Holicz, javiereguiluz) Move JavaScript to seperate file Remove section about forms using validation Removed extra class Update fomr testing sentence Renamed TestedTypeTests to TestedTypeTest ...
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Jan 10, 2018
* 3.4: (30 commits) add note about same-state transitions minor symfony#8205 Move JavaScript to separate file (technetium, javiereguiluz) [Workflow] Document the new transition completed event [error_pages] Removing misleading checker in code example fix syntax errors and add some more crosslinks Updated LDAP documentation for Symfony 3.1 Updating example README to match note below it Update docs for setting custom response code in exception handler add default option value for collection type minor symfony#8831 Update collection.rst (babaorum) minor symfony#8987 Fix YAML config bug (Holicz, javiereguiluz) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged into all version branches