Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix YAML config bug #8987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2018
Merged

Fix YAML config bug #8987

merged 2 commits into from
Jan 7, 2018

Conversation

Holicz
Copy link
Contributor

@Holicz Holicz commented Jan 5, 2018

Should be merged into all version branches

Should be merged into all version branches
@xabbuh
Copy link
Member

xabbuh commented Jan 5, 2018

Can you explain why you think that this is wrong?

@weaverryan
Copy link
Member

Oh! I might see it. The YAML is correct. But the XML and PHP don't match up with the YAML. The XML and PHP versions are what need to be updated :)

@javiereguiluz
Copy link
Member

Thanks @Holicz.

@javiereguiluz javiereguiluz merged commit ee96ffa into symfony:3.4 Jan 7, 2018
javiereguiluz added a commit that referenced this pull request Jan 7, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

Fix YAML config bug

Should be merged into all version branches

Commits
-------

ee96ffa Fixed the XML and PHP config instead of the YAML config
876d572 Fix YAML config bug
@xabbuh xabbuh added this to the 3.3 milestone Jan 8, 2018
xabbuh pushed a commit that referenced this pull request Jan 8, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

Fix YAML config bug

Should be merged into all version branches

Commits
-------

ee96ffa Fixed the XML and PHP config instead of the YAML config
876d572 Fix YAML config bug
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jan 10, 2018
* 3.3: (22 commits)
  add note about same-state transitions
  minor symfony#8205 Move JavaScript to separate file (technetium, javiereguiluz)
  [error_pages] Removing misleading  checker in code example
  Updated LDAP documentation for Symfony 3.1
  Updating example README to match note below it
  Update docs for setting custom response code in exception handler
  add default option value for collection type
  minor symfony#8831 Update collection.rst (babaorum)
  minor symfony#8987 Fix YAML config bug (Holicz, javiereguiluz)
  Move JavaScript to seperate file
  Remove section about forms using validation
  Removed extra class
  Update fomr testing sentence
  Renamed TestedTypeTests to TestedTypeTest
  ...
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jan 10, 2018
* 3.4: (30 commits)
  add note about same-state transitions
  minor symfony#8205 Move JavaScript to separate file (technetium, javiereguiluz)
  [Workflow] Document the new transition completed event
  [error_pages] Removing misleading  checker in code example
  fix syntax errors and add some more crosslinks
  Updated LDAP documentation for Symfony 3.1
  Updating example README to match note below it
  Update docs for setting custom response code in exception handler
  add default option value for collection type
  minor symfony#8831 Update collection.rst (babaorum)
  minor symfony#8987 Fix YAML config bug (Holicz, javiereguiluz)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants