-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[FrameworkBundle] cache:pool:delete command #9628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
components/cache/cache_pools.rst
Outdated
@@ -140,6 +151,10 @@ when all items are successfully deleted):: | |||
# clears the "cache.validation" and "cache.app" pool | |||
$ php bin/console cache:pool:clear cache.validation cache.app | |||
|
|||
.. versionadded:: 4.1 | |||
|
|||
The ``cache:pool:delete`` command was introduced in Symfony 4.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence needs to be indented by four spaces.
components/cache/cache_pools.rst
Outdated
@@ -140,6 +151,10 @@ when all items are successfully deleted):: | |||
# clears the "cache.validation" and "cache.app" pool | |||
$ php bin/console cache:pool:clear cache.validation cache.app | |||
|
|||
.. versionadded:: 4.1 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the blank line must be removed
|
||
.. code-block:: terminal | ||
|
||
$ php bin/console cache:pool:delete <cache-pool-name> <cache-key-name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one thing that is not clear for me here is how you get the list of cache pool names :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You configured them yourself in the framework.cache
section. Do you think we need to clarify that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. Isn't there app
and system
as well by default?
Thanks for this contribution! We've merged it and opened #9782 to not forget about the issue mentioned by @theofidry |
This fixes #9454.