Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] cache:pool:delete command #9628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2018
Merged

[FrameworkBundle] cache:pool:delete command #9628

merged 1 commit into from
May 16, 2018

Conversation

snoek09
Copy link

@snoek09 snoek09 commented Apr 20, 2018

This fixes #9454.

@@ -140,6 +151,10 @@ when all items are successfully deleted)::
# clears the "cache.validation" and "cache.app" pool
$ php bin/console cache:pool:clear cache.validation cache.app

.. versionadded:: 4.1

The ``cache:pool:delete`` command was introduced in Symfony 4.1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence needs to be indented by four spaces.

@@ -140,6 +151,10 @@ when all items are successfully deleted)::
# clears the "cache.validation" and "cache.app" pool
$ php bin/console cache:pool:clear cache.validation cache.app

.. versionadded:: 4.1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the blank line must be removed

@xabbuh xabbuh changed the base branch from master to 4.1 May 8, 2018 08:39

.. code-block:: terminal

$ php bin/console cache:pool:delete <cache-pool-name> <cache-key-name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing that is not clear for me here is how you get the list of cache pool names :/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You configured them yourself in the framework.cache section. Do you think we need to clarify that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. Isn't there app and system as well by default?

@javiereguiluz
Copy link
Member

Thanks for this contribution! We've merged it and opened #9782 to not forget about the issue mentioned by @theofidry

@javiereguiluz javiereguiluz merged commit 8136cbf into symfony:4.1 May 16, 2018
javiereguiluz added a commit that referenced this pull request May 16, 2018
This PR was merged into the 4.1 branch.

Discussion
----------

[FrameworkBundle] cache:pool:delete command

This fixes #9454.

Commits
-------

8136cbf add cache:pool:delete command
@snoek09 snoek09 deleted the cache-pool-delete-command branch May 16, 2018 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants