Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 14, 2019. It is now read-only.

Installation dev/beta versions (143) #159

Closed
wants to merge 1 commit into from
Closed

Installation dev/beta versions (143) #159

wants to merge 1 commit into from

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented May 11, 2015

Hi

Here is my PR according to the comments on #144 PR

Question:

capture d ecran 2015-05-11 a 11 52 48
capture d ecran 2015-05-11 a 11 26 20

Docs if PR accepted
Screenshot when BETA2 was not released yet

@stof
Copy link
Member

stof commented Aug 1, 2015

What would dev resolve to ? Note that it cannot resolve to the dev branch as archives are only available for releases

@javiereguiluz
Copy link
Member

@94noni thanks for submitting this pull request. I've finished it in #185 to simplify it a bit and rebase it. I've reused your original commits, so you'll get full credit for your work. Thanks.

@94noni
Copy link
Contributor Author

94noni commented Sep 11, 2015

👍 :)

javiereguiluz added a commit that referenced this pull request Sep 28, 2015
…oni, javiereguiluz)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Improve the installation of -dev and -BETA versions

This finishes #159, which is related to #144 and #143.

The new behavior of the installer:

1) When installing a regular Symfony version, nothing changes from the previous installer.

2) When you install a `beta` version, you see a warning message:

![symfony-unstable-warning](https://cloud.githubusercontent.com/assets/73419/9811676/f14b6d02-5878-11e5-9220-301fcb671c8c.png)

3) When you try to install a `dev` version, you get a better error message and a link to the article that will solve your problem:

![symfony-dev-version](https://cloud.githubusercontent.com/assets/73419/9811642/c0bdc194-5878-11e5-9ee8-9af5e194f80b.png)

Commits
-------

6751701 Fixed again one test
3ea393a Fixed one test
f45a29a Fixed again the version parser regexp
165813c Added new tests for BETA and RC versions
9e41335 Updated the version parser regular expression
b26b217 Added support for RC versions and normalized version names
31765ca Made comparisons case insensitive because Composer doesn't differentiate 'BETA1' from 'beta1'
9b3cdc1 The trailing number is only available for BETA versions not for 'dev' versions
d03938f Fixed syntax issues
d67b4ad Improved the error message for "-dev" versions
4c26d2b Warn the user when downloading an unstable version
94a1f98 Simplified the new feature a bit
d58812a Installation dev/beta versions (143)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants